Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

도메인 중심적인 코드로 리팩토링 #286

Open
softpeanut opened this issue Jan 8, 2023 · 0 comments · Fixed by #299
Open

도메인 중심적인 코드로 리팩토링 #286

softpeanut opened this issue Jan 8, 2023 · 0 comments · Fixed by #299
Assignees
@softpeanut
Labels
refactor 코드 리팩토링 할 경우

Comments

@softpeanut
Copy link
Member

softpeanut commented Jan 8, 2023 •
edited by khcho0125
Loading

AS-IS

  • 비즈니스 로직 및 객체들이 중구난방하게 흩어져 있음
  • 비즈니스 로직과 도메인 로직의 구분이 안됨

TO-BE

  • 명확하게 분리해 코드 가독성 증진하기
  • Value Object 사용을 늘려 객체 지향적인 코드 작성하기
  • Domain의 SPI Application으로 이동

Additional

  • Web Request → Application Data 변환 구성
@softpeanut softpeanut added the refactor 코드 리팩토링 할 경우 label Jan 8, 2023
@softpeanut softpeanut self-assigned this Jan 8, 2023
@softpeanut softpeanut moved this from Todo to In Progress in SimTong-Backend Backlog Jan 9, 2023
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) AuthCode Aggregate 구성
c370696
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) AuthCode Aggregate 변경사항 반영
512ac92
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) AuthCodeMapper 직접 구현
d9b0c05
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) AuthCode Aggregate 변경사항 반영
22fe8f4
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) AuthCodeLimit Aggregate 리팩토링
86047c0
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) AuthCodeLimit Aggregate 변경사항 반영
9e93bbc
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) 가독성 증진
ad38208
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
test: (#286) 테스트 코드 반영
59fcac1
This was referenced Jan 9, 2023
Closed
Open
Merged
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
merge: (#286) AuthCode, AuthCodeLimit 도메인 리팩토링 (#292)
3e7aabe
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) Holiday Aggregate 리팩토링
a2fa3bb
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) Holiday Aggregate 리팩토링
14f933c 
refactor: (#286) Holiday Aggregate 리팩토링
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
test: (#286) 테스트 코드 반영
11c81ce
@softpeanut softpeanut mentioned this issue Jan 9, 2023
Merged
4 tasks
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) share() -> complete()
71a7afc
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
merge: (#286) Holiday 도메인 리팩토링 (#294)
6cd4164
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) 줄바꿈
4fe7f59
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
refactor: (#286) 줄바꿈
b69c08c
@softpeanut softpeanut mentioned this issue Jan 9, 2023
Merged
4 tasks
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
chore: (#286) 누락된 @aggregate 추가
ad1379e
softpeanut added a commit that referenced this issue Jan 9, 2023
@softpeanut
merge: (#286) File, Menu Aggregate, Notification 도메인 리팩토링 (#296)
56a3336
khcho0125 added a commit that referenced this issue Jan 9, 2023
@khcho0125
chore: (#286) SPI Domain → Application 계층 이동
4bd4f0c
khcho0125 added a commit that referenced this issue Jan 9, 2023
@khcho0125
chore: (#286) import 변경사항
81e8daf
khcho0125 added a commit that referenced this issue Jan 9, 2023
@khcho0125
chore: (#286) .gitkeep
bd6db2c
@khcho0125 khcho0125 mentioned this issue Jan 9, 2023
Merged
4 tasks
khcho0125 added a commit that referenced this issue Jan 10, 2023
@khcho0125
revert: (#286) schedule → file 실수
027399a
softpeanut added a commit that referenced this issue Jan 10, 2023
@softpeanut
refactor: (#286) Schedule Aggregate 리팩토링
3247be6
softpeanut added a commit that referenced this issue Jan 10, 2023
@softpeanut
chore: (#286) checkOwner 비교 구문식 수정
a2b5bc1
softpeanut added a commit that referenced this issue Jan 10, 2023
@softpeanut
chore: (#286) 같은 지점 비교 구문식 수정
49095d8
softpeanut added a commit that referenced this issue Jan 10, 2023
@softpeanut
test: (#286) 테스트 코드 반영
69a98f2
softpeanut added a commit that referenced this issue Jan 10, 2023
@softpeanut
chore: (#286) remove mapstruct default argument
b0ff42b
@softpeanut softpeanut mentioned this issue Jan 10, 2023
Merged
4 tasks
khcho0125 added a commit that referenced this issue Jan 10, 2023
@khcho0125
chore: (#286) vo 패키지 이동
21bdf25
khcho0125 added a commit that referenced this issue Jan 10, 2023
@khcho0125
merge: (#286) SPI 구조 변경 (#297)
4cab708
softpeanut added a commit that referenced this issue Jan 10, 2023
@softpeanut
merge: (#286) Schedule 도메인 리팩토링 (#298)
ffddcb0
softpeanut added a commit that referenced this issue Jan 10, 2023
@softpeanut
refactor: (#286) 직원 명시
729ecb0
softpeanut added a commit that referenced this issue Jan 10, 2023
@softpeanut
chore: (#286) 누락된 @aggregate 추가
6b592cc
@softpeanut softpeanut mentioned this issue Jan 10, 2023
Merged
4 tasks
softpeanut added a commit that referenced this issue Jan 10, 2023
@softpeanut
refactor: (#286) 정렬까지 슬쩍
8ed87d1
softpeanut added a commit that referenced this issue Jan 10, 2023
@softpeanut
merge: (#286) 도메인 용어 적용 (#299)
5bcad8a
softpeanut added a commit that referenced this issue Jan 11, 2023
@softpeanut
refactor: (#286) User Aggregate 리팩토링
eaedc96
softpeanut added a commit that referenced this issue Jan 11, 2023
@softpeanut
chore: (#286) javadoc 추가
121a19c
softpeanut added a commit that referenced this issue Jan 13, 2023
@softpeanut
refactor: (#286) SignUpUseCase 가독성
4d8a59a
@softpeanut softpeanut mentioned this issue Jan 13, 2023
Merged
4 tasks
softpeanut added a commit that referenced this issue Jan 13, 2023
@softpeanut
test: (#286) 테스트 코드 반영
e36c2db
khcho0125 added a commit that referenced this issue Jan 13, 2023
@khcho0125
refactor: (#286) toDomain 간편화
373def6
softpeanut added a commit that referenced this issue Jan 13, 2023
@softpeanut
refactor: (#286) of method 위치
527c46b
softpeanut added a commit that referenced this issue Jan 13, 2023
@softpeanut
merge: (#286) User 도메인 리팩토링 (#307)
0bd21fc
@khcho0125 khcho0125 moved this from In Progress to Done in SimTong-Backend Backlog Jan 23, 2023
@khcho0125 khcho0125 moved this from Done to In Progress in SimTong-Backend Backlog Jan 23, 2023
@khcho0125 khcho0125 moved this from In Progress to Done in SimTong-Backend Backlog Jan 24, 2023
@khcho0125 khcho0125 moved this from Done to In Progress in SimTong-Backend Backlog Jan 24, 2023
@khcho0125 khcho0125 moved this from In Progress to Done in SimTong-Backend Backlog Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@softpeanut softpeanut

Labels
refactor 코드 리팩토링 할 경우
Projects
SimTong-Backend Backlog
Status: Done
Milestone
No milestone
1 participant
@softpeanut