feat: Structure actors and its packet handling #1
+461
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwiyou
requested changes
Apr 5, 2020
src/core/server.rs
Outdated
| use std::collections::HashMap; | ||
|
|
||
| #[derive(Clone, Default)] | ||
| pub struct Server { |
There was a problem hiding this comment.
Actor 디자인 상 전체를 관리하는 개념이 아니라 각각의 역할 분담하는 구조라, Server를 만들기보다 User를 가지고 있는 Lobby와 Room 정보를 가지고 있는 RoomManager로 분리하면 좋을 것 같아요.
There was a problem hiding this comment.
611fe11 에서 Lobby와 RoomManager로 분리했습니다. 더 개선이 필요할까요?
src/websocket.rs
Outdated
| */ | ||
| trace!("{}", &text); | ||
| if let Ok(message) = serde_json::from_str::<PacketClient>(&text) { | ||
| self.server.do_send(message); |
There was a problem hiding this comment.
전송 실패할 경우 (actix mailbox full 등의 이유로) remote에 알려줄 필요가 있습니다.
There was a problem hiding this comment.
611fe11 에서 구조를 변경해, WsSession의 또 다른 Handler 구현이 처리하도록 넘겨줍니다. 더 개선이 필요할까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.