Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Structure actors and its packet handling #1
base: master
Are you sure you want to change the base?
feat: Structure actors and its packet handling #1
Changes from 7 commits
4ee724b
e59b7ec
8c21f7b
b18176b
73f7315
7390e66
a0bcd36
ed8f1e7
e2c8c97
5cb8375
af00621
611fe11
2d7ded4
8b5a7e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actor 디자인 상 전체를 관리하는 개념이 아니라 각각의 역할 분담하는 구조라, Server를 만들기보다 User를 가지고 있는 Lobby와 Room 정보를 가지고 있는 RoomManager로 분리하면 좋을 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
611fe11 에서 Lobby와 RoomManager로 분리했습니다. 더 개선이 필요할까요?