Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use encoding: false when copying files using gulp. #7340

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Use encoding: false when copying files using gulp. #7340

merged 2 commits into from
Nov 29, 2024

Commits on Nov 29, 2024

  1. Use encoding: false when copying files using gulp. 

    Assets we copy from third party libs include binary files like images, wasm builds etc.
Gulp5 by default re-encodes copied files as utf-8 which breaks copying of binary files.
By, setting `encoding: false` gulp treats all copied files as binary,
reverting to the previous behaviour.
    @na9da
    na9da committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    f243345 View commit details
    Browse the repository at this point in the history

  2. Update CHANGES.md.

    @na9da
    na9da committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    8ba7a48 View commit details
    Browse the repository at this point in the history