Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint version #7422

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Bump golangci-lint version #7422

merged 2 commits into from
Dec 4, 2024

Conversation

halimi
Copy link
Contributor

@halimi halimi commented Dec 3, 2024

Summary

Bump golangci-lint version because from v1.60.1 supports go1.23
https://github.com/golangci/golangci-lint/releases/tag/v1.60.1

Replace the deprecated check.
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.

Changes

  • Bump golangci-lint version
  • Replace deprecated exportloopref check

Testing

Steps

...

Results
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@halimi halimi marked this pull request as ready for review December 3, 2024 14:42
@halimi halimi requested review from a team as code owners December 3, 2024 14:42
@halimi halimi self-assigned this Dec 3, 2024
@halimi halimi added this to the v3.33.1 milestone Dec 3, 2024
@halimi halimi merged commit 1448748 into v3.33 Dec 4, 2024
5 checks passed
@halimi halimi deleted the fix/golangci-lint-version branch December 4, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants