Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint version #7422

Merged
merged 2 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@ name: Go Code
on:
pull_request:
paths:
- ".github/workflows/go.yml"
- "*.go"
- ".revive.toml"
- "cmd/**"
- "go.mod"
- "go.sum"
- "Makefile"
- "pkg/**"
- "!pkg/webui/**"
- "pkg/webui/**.go"
- "tools/**"
- '.github/workflows/go.yml'
- '*.go'
- '.revive.toml'
- 'cmd/**'
- 'go.mod'
- 'go.sum'
- 'Makefile'
- 'pkg/**'
- '!pkg/webui/**'
- 'pkg/webui/**.go'
- 'tools/**'

jobs:
quality:
Expand Down Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Lint code
uses: golangci/golangci-lint-action@v6
with:
version: v1.57.2
version: v1.62.2
only-new-issues: true
args: --timeout=10m ./pkg/... ./cmd/...

Expand All @@ -56,15 +56,15 @@ jobs:
postgres:
image: postgres
ports:
- "5432/tcp"
- '5432/tcp'
env:
POSTGRES_USER: root
POSTGRES_PASSWORD: root
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
redis:
image: redis:7
ports:
- "6379/tcp"
- '6379/tcp'
timeout-minutes: 15
steps:
- name: Create ttn_lorawan_is_test DB
Expand All @@ -85,11 +85,11 @@ jobs:
if: "${{ env.AWS_REGION != '' }}"
uses: aws-actions/configure-aws-credentials@v4
with:
aws-region: "${{ secrets.AWS_REGION }}"
role-to-assume: "arn:aws:iam::${{ secrets.AWS_USER_ID }}:role/${{ secrets.AWS_ROLE_NAME }}"
role-session-name: "${{ secrets.AWS_ROLE_NAME }}-${{ github.job }}-${{ github.run_id }}"
aws-region: '${{ secrets.AWS_REGION }}'
role-to-assume: 'arn:aws:iam::${{ secrets.AWS_USER_ID }}:role/${{ secrets.AWS_ROLE_NAME }}'
role-session-name: '${{ secrets.AWS_ROLE_NAME }}-${{ github.job }}-${{ github.run_id }}'
env:
AWS_REGION: "${{ secrets.AWS_REGION }}"
AWS_REGION: '${{ secrets.AWS_REGION }}'
- name: Check out code
uses: actions/checkout@v4
- name: Install Go and Dependencies
Expand All @@ -101,10 +101,10 @@ jobs:
- name: Test code
env:
SQL_DB_ADDRESS: localhost:${{ job.services.postgres.ports['5432'] }}
SQL_DB_AUTH: "root:root"
SQL_DB_AUTH: 'root:root'
REDIS_ADDRESS: localhost:${{ job.services.redis.ports['6379'] }}
TEST_REDIS: "1"
TEST_SLOWDOWN: "8"
TEST_REDIS: '1'
TEST_SLOWDOWN: '8'
GCP_CREDENTIALS: ${{ secrets.GCP_TEST_CREDENTIALS }}
TEST_BUCKET: ttn-lorawan-test
run: tools/bin/mage go:test
Expand Down
2 changes: 1 addition & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ linters:
# Enabled manually:
- asciicheck # Finds non-ASCII identifiers.
- bodyclose # Finds HTTP response bodies that are not closed.
- copyloopvar # Finds for loop variables that are overwritten.
- errorlint # Finds problems with error wrapping.
- exportloopref # Finds pointers to range variables.
- goconst # Finds repeated strings that could be replaced by a const.
- gocyclo # Finds funcs with high cyclomatic complexity.
- godot # Finds comments that do not end with a period.
Expand Down
Loading