Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Network layer BatteryPercentage to ApplicationUplink #7449

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

halimi
Copy link
Contributor

@halimi halimi commented Dec 18, 2024

Summary

References: #7427

The Network Server already receives the battery percentage via the DevStatus MAC command and stores it. We can forward this value to the Application Server in the ApplicationUplink message.

Changes

  • Extend the ApplicationUplink message with the LastBatteryPercentage message
  • Add the stored values during the uplink match

Testing

Steps
  • Use TTS with a real device
  • Check the application uplink message, it should contain the Last Battery Percentage in [0, 100] interval
Results
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@halimi halimi self-assigned this Dec 18, 2024
@halimi halimi added this to the v3.33.1 milestone Dec 18, 2024
@github-actions github-actions bot added the c/network server This is related to the Network Server label Dec 18, 2024
@halimi halimi force-pushed the feature/7427-battery-percentage branch from f035a81 to 3ddac1b Compare December 18, 2024 16:46
@halimi halimi marked this pull request as ready for review December 19, 2024 10:50
@halimi halimi requested a review from a team as a code owner December 19, 2024 10:50
@halimi halimi requested a review from johanstokking December 19, 2024 10:50
@halimi halimi force-pushed the feature/7427-battery-percentage branch from f0668ce to 6d2c5f5 Compare January 21, 2025 13:59
@halimi halimi requested a review from johanstokking January 21, 2025 14:41
@halimi halimi force-pushed the feature/7427-battery-percentage branch from 6d2c5f5 to d63d032 Compare January 22, 2025 12:29
@halimi halimi merged commit 46220fd into v3.33 Jan 22, 2025
11 of 16 checks passed
@halimi halimi deleted the feature/7427-battery-percentage branch January 22, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/network server This is related to the Network Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants