Skip to content

Commit

Permalink
remote: warn about unhandled branch.<name>.rebase values
Browse files Browse the repository at this point in the history
We ignore them silently, but it actually makes sense to warn the users
that their config setting has no effect.

Signed-off-by: Johannes Schindelin <[email protected]>
Reviewed-by: Ævar Arnfjörð Bjarmason <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
dscho authored and gitster committed Sep 8, 2021
1 parent 6df8755 commit ab7c7c2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions builtin/remote.c
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,9 @@ static int config_read_branches(const char *key, const char *value, void *cb)
* truth value with >= REBASE_TRUE.
*/
info->rebase = rebase_parse_value(value);
if (info->rebase == REBASE_INVALID)
warning(_("unhandled branch.%s.rebase=%s; assuming "
"'true'"), name, value);
break;
case PUSH_REMOTE:
if (info->push_remote_name)
Expand Down

0 comments on commit ab7c7c2

Please sign in to comment.