Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly determine the host of a chess game on initialization #234

Merged
merged 1 commit into from
Nov 26, 2023

Properly determine the host of a chess game on initialization

03987f4
Select commit
Loading
Failed to load commit list.
Merged

fix: Properly determine the host of a chess game on initialization #234

Properly determine the host of a chess game on initialization
03987f4
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Nov 26, 2023 in 0s

2 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : fix: Properly determine the host of a chess game on initialization
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : We previously used the length of the invite packet to determine if we were the host of a chess game. This allowed a friend to send an invite packet with a length of zero to trick you into starting a game of chess with yourself as the host. The effect of this was just a broken game in which neither peer could make a move.

We now determine who the host is independently and in addition do more thorough packet size enforcement


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}