Add config warnings for texture size/format/mipmap mismatch #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokisanGames
force-pushed
the
config-warnings
branch
from
5d88eae to
b987649
Compare
TokisanGames
added
enhancement
TokisanGames
force-pushed
the
config-warnings
branch
from
b987649 to
3145c30
Compare
|
Looks good. The only thing that I can think of to add, would be a console warning if there is a "generated" texture present, especially in the normal map array, someone could add a lot of textures and miss one. |
TokisanGames
force-pushed
the
config-warnings
branch
from
3145c30 to
5f64536
Compare
|
Great idea, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542
Add SceneTree (config) warnings for:
Add console warnings for textures:
@Xtarsia Would you review this please? Are there any config warnings we should add?
Compatibility mode && albedo/normal is compressed is probably fine as a warning since it works and can be ignored. Config warnings is a nag screen, so should be considered "must dos".