Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge all trailing whitespace #1734

Merged
merged 2 commits into from
Mar 6, 2024
Merged

purge all trailing whitespace #1734

merged 2 commits into from
Mar 6, 2024

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Feb 28, 2024

Changes

  • LF line endings (CRLF for *.bat)
  • strip trailing space after lines
  • fix trailing space at file ends

Testing you performed

Related issues/links

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@casperdcl casperdcl self-assigned this Feb 28, 2024
@casperdcl casperdcl requested a review from a team February 28, 2024 17:06
@casperdcl casperdcl changed the title whitespace purge all trailing whitespace Feb 28, 2024
Copy link
Member

@MargaretDuff MargaretDuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it is just whitespace only changes and ends of files!

Just a thought - at the software sustainability hackathon we discussed ways of keeping track of who had authored/changed what part of the code for licensing/copyright reasons. PRs like this make it difficult to keep track through git. I don't know what we agreed?

@casperdcl casperdcl mentioned this pull request Feb 29, 2024
9 tasks
@paskino
Copy link
Contributor

paskino commented Mar 6, 2024

I believe we should also discuss about coding standards. I think these changes are applied by your code editor or other tools to abide to some coding standard.

It would be better if we used such tools when developing. I don't know if the pre-commit that is in eqt is what we want, though?

@casperdcl
Copy link
Member Author

casperdcl commented Mar 6, 2024

I intend to squashmerge this with a bot username (@github-actions[bot]) plus ignore the commit so it's not associated with my user.

Also yes long-term we need an eqtesque solution in cil, but that's blocked on TomographicImaging/eqt#98

github-actions bot and others added 2 commits March 6, 2024 14:01
- dos2unix
- strip trailing space
- fix file endings
@casperdcl casperdcl merged commit 3231549 into master Mar 6, 2024
3 checks passed
@casperdcl casperdcl deleted the whitespace branch March 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants