Spider: ethernet: fix ethernet issues and extend port usage #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pedantic build flag provides useless warnings about unnamed structures when building the ethernet drivers in spider platform. Let's remove this flag since it does not provide any benefit in this case. Signed-off-by: Valerio Setti <[email protected]>
Previous implementation had some hard coded initialization for only TSN0 which, of course, made it impossible to use also TSN1 and TSN2. This commit fix this limitation. Now the desired TSN port can be selected at build time by properly setting the TSN_PORT_IN_USE symbol in rswitch.c source file. It should be noted that only 1 single port can be used at a time and it must be selected while building the firmware. There is no auto detection feature or similar supported so far. Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Without this fix it can happen that the descriptors read from CR52 are not aligned with the RAM content which results in no operation on the received data. This is of course not correct and due to a misalignment between the RAM content and L1 cache. This commits resolves this issue by invalidating L1 cache before reading descriptors. Signed-off-by: Valerio Setti <[email protected]>
jlbirccyn
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves 2 issues:
It gives the user the possibility to select any TSN port between TSN0, TSN1 or TSN2 for Ethernet communication.
It solves an issue with
L1 cache<->RAMalignement which can prevent the ethernet driver and examples to work properly