fix(alerting): Add missing support for default-alert on teams-workflows #883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed some weird behaviour where I wasn't getting alert resolved notifications through the new teams-workflows provider, while other alerting providers were working with the same config.
I went spelunking and while doing so, noticed teams-workflows was missing from the configuredProviders list at startup, even though it was sending alerts. This led me on the path to making the changes in the PR, which seem to have resolved the default-alerts issue.
Example config where aws-ses was working, while teams-workflow was not.
Checklist
README.md
, if applicable.