Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gof_cancer rule from default logic but allow it if it exists #64

Merged
merged 3 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ The BMDS Desktop has a startup screen where you can select which database file y

## Disclaimer

The United States Environmental Protection Agency (EPA) GitHub project code is provided on an "as is" basis and the user assumes responsibility for its use. EPA has relinquished control of the information and no longer has responsibility to protect the integrity , confidentiality, or availability of the information. Any reference to specific commercial products, processes, or services by service mark, trademark, manufacturer, or otherwise, does not constitute or imply their endorsement, recommendation or favoring by EPA. The EPA seal and logo shall not be used in any manner to imply endorsement of any commercial product or activity by EPA or the United States Government. Any reference to specific commercial products, processes, or services by service mark, trademark, manufacturer, or otherwise, does not constitute or imply their endorsement, recommendation or favoring by EPA. The EPA seal and logo shall not be used in any manner to imply endorsement of any commercial product or activity by EPA or the United States Government.
The United States Environmental Protection Agency (EPA) GitHub project code is provided on an "as is" basis and the user assumes responsibility for its use. EPA has relinquished control of the information and no longer has responsibility to protect the integrity, confidentiality, or availability of the information. Any reference to specific commercial products, processes, or services by service mark, trademark, manufacturer, or otherwise, does not constitute or imply their endorsement, recommendation or favoring by EPA. The EPA seal and logo shall not be used in any manner to imply endorsement of any commercial product or activity by EPA or the United States Government.
5 changes: 4 additions & 1 deletion frontend/src/components/Logic/RuleTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {inject, observer} from "mobx-react";
import PropTypes from "prop-types";
import React, {Component} from "react";

import {ruleOrder} from "@/constants/logicConstants";
import {optionalRules, ruleOrder} from "@/constants/logicConstants";

import RuleRow from "./RuleRow";

Expand Down Expand Up @@ -32,6 +32,9 @@ class RuleList extends Component {
<tbody>
{ruleOrder.map(ruleName => {
const ruleIndex = _.findIndex(rules, d => d.rule_class === ruleName);
if (ruleIndex === -1 && _.includes(optionalRules, ruleName)) {
return null;
}
return (
<RuleRow
key={ruleName}
Expand Down
1 change: 1 addition & 0 deletions frontend/src/constants/logicConstants.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export const RULES = Object.freeze({
RULES.CONTROL_STDEV_FIT,
RULES.DOF_ZERO,
],
optionalRules = [RULES.GOF_CANCER],
ruleLookups = {
[RULES.BMD_MISSING]: {
notes: val => "BMD not estimated",
Expand Down