Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify tables to add NIDS Super High Res 0.5 deg reflectivity #71

Closed
wants to merge 5 commits into from

Conversation

pjpokran
Copy link
Contributor

@pjpokran pjpokran commented Mar 3, 2022

These are the changes I made to allow nex2gini to create composites using the new N0B super high res reflectivity (used to use N0Q)

@mzuranski
Copy link
Contributor

This is more complete than what I had done (#67) and I'm wondering if these changes to nex2gini.tbl will fix my issue with the color bar labels as I missed that file.

@akrherz
Copy link
Collaborator

akrherz commented Mar 3, 2022

I am on the case today about this and have an issue #72 tracking it. Thanks for the swing at this @pjpokran, I think a bit of wordsmithing is needed yet... The initial worry is that there are hard coded GEMPAK array size limits that will bomb out with these files. Good luck all with this effort!

@akrherz
Copy link
Collaborator

akrherz commented Mar 3, 2022

Hi @pjpokran, so there's one big issue here with your PR, you made it from your local main branch, which makes it somewhat tough to manage the lifecycle of your pull request. The best practice is to generally first create a new branch dedicated to your PR, commit your code changes to that branch and then push that branch up to github and create the pull request from it.

I'm gonna create a new PR #73 with your commits cherry-picked and then iterate some on it. Thanks for getting this ball rolling!

@akrherz akrherz closed this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants