Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Level III Super Res #73

Merged
merged 12 commits into from
Mar 4, 2022
Merged

Support Level III Super Res #73

merged 12 commits into from
Mar 4, 2022

Conversation

akrherz
Copy link
Collaborator

@akrherz akrherz commented Mar 3, 2022

refs #72
obsoletes #71

Pull request that implements code/table changes necessary to support NEXRAD Level III super res. Thanks to @pjpokran for getting this PR off to an excellent start!

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 3, 2022

@pjpokran I found your added upc_n0q.tbl to be identical to the already bundled upc_ref2.tbl. With ac07fcd, I consolidated this back down. Is there a reason this was added that I am unaware of?

@pjpokran
Copy link
Contributor

pjpokran commented Mar 3, 2022

@akrherz I didn't realize that table was there. My radar composites are running with an older version of GEMPAK that didn't have that upc_ref2.tbl. If it's identical, that's fine. But you'll have to update the line in gempak/tables/sat/imgtyp.tbl as well, since it's using my file name.

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 3, 2022

I think I am done tweaking for now, anybody wish to review this? @mzuranski @pjpokran ?

@mzuranski
Copy link
Contributor

I'm following along with these changes, trying to adjust my 7.5.1 install, but I'm still seeing IMCBAR frequency ignored. This image was made with IMCBAR = 31/V/CR/.98;.5/.84;.02/-10 The only other difference I can think of is I'm running Ubuntu but I don't see how that could be related. Can others verify if IMCBAR frequency works for them or not on 7.14?

test_N0B_gempak

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 3, 2022

I get the same thing, nevermind my comment about frequency. I am looking into this more.

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 3, 2022

Ah, gempak/source/gemlib/im/imcbar.f has special codes to handle this. Testing a patch now....

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 3, 2022

Getting close 🙃
ss

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 3, 2022

  • Good: N0B, N0G nicely displays now in nmap2 gpmap
  • Bad: N0Q does not display nicely :( I fouled up more tables with the NCEP 7.14.0 merge. bad daryl!

@pjpokran
Copy link
Contributor

pjpokran commented Mar 3, 2022

Daryl, this all looks good to me. I haven't tested any of your other changes since I'm not using other angles, but on paper they all look good. Thanks for all the additional work on this!

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 3, 2022

So, of concern now is that GEMPAK seems to think N0Q starts at -32 dbz and N0B at -33 dbz. Similar off by one knot with N0U and N0G, I've hacked around that now.

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 3, 2022

I'm done tinkering with this PR and will follow up with others as I find things to fix :/

@sebenste
Copy link

sebenste commented Mar 4, 2022

Just curious, what command syntax did you use to make that national mosaic?

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 4, 2022

Just curious, what command syntax did you use to make that national mosaic?

Just nex2img

@pjpokran
Copy link
Contributor

pjpokran commented Mar 4, 2022

Gilbert - I'm writing up an email to another explaining how I do the mosiacs - when I'm done I can forward that and the script/etc to you.

@sebenste
Copy link

sebenste commented Mar 4, 2022

Great, thanks!

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 4, 2022

I don't know of further feedback coming on this and can easily followup with issues folks find with any testing that comes. I have some more cosmetic things to tweak overtop this PR, so want to get it in now to keep merge nightmares limited.

@akrherz akrherz merged commit 3411d85 into Unidata:main Mar 4, 2022
@akrherz akrherz deleted the gh72_superres branch March 4, 2022 21:17
@mzuranski
Copy link
Contributor

@akrherz Since this is going to get closed out soon, how would you feel if I opened a new issue for imcbar frequency?

The 7.5.1 documentation states:

Frequency describes the levels to be labeled. If the frequency is
positive, the labels are plotted on the right/top of the color bar.
If it is negative, the labels are plotted on the left/bottom of the
color bar. The default is -1.

...and that's it.

Granted those docs are now obsolete, they're still the best we've got (as far as I'm aware). While I'm not expecting a change to the behavior anytime soon, I would at least like it noted someplace that the frequency value is ignored for certain products as to avoid confusion.

I'll also close out #15 as it's old and probably related to this anyway.

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 4, 2022

how would you feel if I opened a new issue for imcbar frequency?

Yes please, I was going to do the same, but it slipped my mind yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants