Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail a test on purpose for workflow testing #2920

Conversation

lunkwill42
Copy link
Member

No description provided.

@lunkwill42 lunkwill42 requested a review from johannaengland May 16, 2024 07:50
@lunkwill42 lunkwill42 force-pushed the test/failing-test-to-verify-workflow branch from 0d2d5ba to 8fd1240 Compare May 16, 2024 10:16
@lunkwill42
Copy link
Member Author

First attempt: Deliberately fail a test. Draft PR against latest master, from personal fork. No test results published...

@lunkwill42
Copy link
Member Author

Second attempt: Rebased on an older commit that does not include #2914. Still no test results published.

@lunkwill42 lunkwill42 force-pushed the test/failing-test-to-verify-workflow branch from 8fd1240 to 75811f6 Compare May 16, 2024 10:33
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.25%. Comparing base (513c0e4) to head (75811f6).
Report is 2 commits behind head on master.

❗ Current head 75811f6 differs from pull request most recent head e7f5c59. Consider uploading reports for the commit e7f5c59 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2920   +/-   ##
=======================================
  Coverage   60.25%   60.25%           
=======================================
  Files         602      602           
  Lines       44084    44084           
=======================================
  Hits        26565    26565           
  Misses      17519    17519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland
Copy link
Contributor

For another PR that isn't a draft my tests failed as well (after having succeeded before and test results being posted) and the test result comment was not updated. So it looks like the test results are not posted/updated no matter where the PR is/if it is draft or not, as long as the tests fail.

@lunkwill42
Copy link
Member Author

Third attempt: Rebased back to current master. Fixed failing test. Now there is a CodeCov report, but still no test result published.

@lunkwill42 lunkwill42 marked this pull request as ready for review May 16, 2024 11:05
@lunkwill42 lunkwill42 force-pushed the test/failing-test-to-verify-workflow branch from 75811f6 to 4ab2c80 Compare May 16, 2024 11:06
@lunkwill42
Copy link
Member Author

lunkwill42 commented May 16, 2024

Fourth attempt: Reset to initial conditions of first attempt, but move the PR out of draft mode. Still no test results published.

@lunkwill42 lunkwill42 marked this pull request as draft May 16, 2024 11:14
@lunkwill42
Copy link
Member Author

lunkwill42 commented May 16, 2024

Fourth attempt: Revert back to draft mode. Revert ignore rule for master branch in the publish workflows. Still no test results published

@lunkwill42
Copy link
Member Author

tests are completed, closing

@lunkwill42 lunkwill42 closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants