Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin snmpsim to older version #2946

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Aug 1, 2024

same issue as we had for Zino

A new version of snmpsim was released about 6 hours ago (the first new version in 5 years), and it seems to have changed to be incompatible with how our test suite uses it.

In particular, our test suite expects snmpsimd.py to be available on the search PATH, but the executable's name may have changed, and I don't have the luxury of time to figure out how to adapt our test suite

I assume there may be many more changes, as the original maintainer died a while back, and someone else has taken over, which is why I think it's best to pin to an older version for now.

@stveit stveit self-assigned this Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.35%. Comparing base (b8d6d52) to head (b5a98ce).
Report is 380 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2946   +/-   ##
=======================================
  Coverage   56.35%   56.35%           
=======================================
  Files         603      603           
  Lines       43862    43862           
  Branches       48       48           
=======================================
  Hits        24719    24719           
  Misses      19131    19131           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stveit stveit marked this pull request as ready for review August 1, 2024 13:24
@stveit stveit merged commit 80a97c3 into Uninett:master Aug 2, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants