Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unused variable rule (F841) to ruff #3035

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 25, 2024

As #3026, up for discussion. This also adds F842 - Local variable {name} is annotated but never used.

@johannaengland johannaengland added the discussion Requires developer feedback/discussion before implementation label Sep 25, 2024
@johannaengland johannaengland self-assigned this Sep 25, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

Copy link

github-actions bot commented Sep 25, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 994 0 12.63s
✅ PYTHON ruff 990 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Sep 25, 2024

Test results

    9 files      9 suites   8m 14s ⏱️
2 147 tests 2 147 ✅ 0 💤 0 ❌
4 033 runs  4 033 ✅ 0 💤 0 ❌

Results for commit d581a81.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.33%. Comparing base (5a35066) to head (d581a81).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3035   +/-   ##
=======================================
  Coverage   60.33%   60.33%           
=======================================
  Files         606      606           
  Lines       43700    43700           
  Branches       48       48           
=======================================
  Hits        26366    26366           
  Misses      17322    17322           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MegaLinter check is failing. Maybe this needs to be rebased to the latest master first?

@lunkwill42
Copy link
Member

The MegaLinter check is failing. Maybe this needs to be rebased to the latest master first?

And yeah, apparently I didn't see the big red blocked-label, so I guess my comment is obvious ;)

@johannaengland johannaengland force-pushed the ruff/add-unused-variables-rule branch from 73971f4 to c4931f9 Compare November 25, 2024 12:10
@johannaengland johannaengland force-pushed the ruff/add-unused-variables-rule branch from c4931f9 to bad52cc Compare November 25, 2024 12:22
@johannaengland johannaengland force-pushed the ruff/add-unused-variables-rule branch from bad52cc to c72208e Compare November 29, 2024 09:01
@johannaengland johannaengland force-pushed the ruff/add-unused-variables-rule branch from c72208e to d581a81 Compare November 29, 2024 09:09
Copy link

sonarcloud bot commented Nov 29, 2024

@johannaengland johannaengland merged commit d385dca into master Nov 29, 2024
12 of 13 checks passed
@johannaengland johannaengland deleted the ruff/add-unused-variables-rule branch November 29, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Requires developer feedback/discussion before implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants