Fix obsolete crispy-forms references in UI styleguide #3227
Conversation
We don't use crispy-forms any more, but our internal form template system mimics the subset of crispy-forms that we were once using.
We no longer use crispy-forms, so we don't have any "customizations" of it. Also, we never used Jabber, the IRC channel has been discontinued and we prefer mailing lists to direct, person e-mails, so this wording was also changed.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 31s ⏱️ Results for commit 2c1a9ae. ♻️ This comment has been updated with latest results. |
| There are many customizations done to the crispy forms. Basically, if you | ||
| need to create forms - ask on mail/jabber/irc. | ||
| Use existing forms as examples for how to build your own. If you have questions, ask them | ||
| on the NAV mailing lists or GitHub discussion forums. |
There was a problem hiding this comment.
| on the NAV mailing lists or GitHub discussion forums. | |
| on the NAV mailing list or GitHub discussion forum. |
There was a problem hiding this comment.
Maybe we could even add a link to the discussion forum?
There was a problem hiding this comment.
We have multiple mailing lists. GitHub discussions has what I perceive as multiple forums per repo.
There was a problem hiding this comment.
Contact details are documented elsewhere, I wouldn't want to repeat that here, but point to the relevant documentation.
Co-authored-by: Johanna England <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3227 +/- ##
=======================================
Coverage 60.39% 60.39%
=======================================
Files 605 605
Lines 43687 43687
Branches 48 48
=======================================
Hits 26383 26383
Misses 17292 17292
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
lunkwill42
deleted the
cleanup/fix-obsolete-crispyforms-refs-in-styleguide
branch
Fixes #3180
@podliashanyk may have other suggestions or improvements, but she's on vacation, and we want to remove the original wording before we make a new release. This can easily be improved further at a later date.