Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obsolete crispy-forms references in UI styleguide #3227

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Fix obsolete crispy-forms references in UI styleguide #3227

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c25143d
Change styleguide wording on crispy-forms
lunkwill42 Nov 20, 2024
cee12b1
Fix obsolete crispy-forms and contact reference
lunkwill42 Nov 20, 2024
2c1a9ae
Remove a space
lunkwill42 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/nav/web/templates/styleguide.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,8 @@ <h3 class="underline">Forms</h3>
</ul>

<p>
There are many customizations done to the crispy forms. Basically, if you
need to create forms - ask on mail/jabber/irc.
Use existing forms as examples for how to build your own. If you have questions, ask them
lunkwill42 marked this conversation as resolved.
Show resolved Hide resolved
on the NAV mailing lists or GitHub discussion forums.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on the NAV mailing lists or GitHub discussion forums.
on the NAV mailing list or GitHub discussion forum.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could even add a link to the discussion forum?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have multiple mailing lists. GitHub discussions has what I perceive as multiple forums per repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contact details are documented elsewhere, I wouldn't want to repeat that here, but point to the relevant documentation.

</p>

{% include 'custom_crispy_templates/flat_form.html' with form=form1 %}
Expand Down
Loading