Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: per-peer MTU #2676

Merged
merged 7 commits into from
Aug 30, 2023
Merged

feat: per-peer MTU #2676

merged 7 commits into from
Aug 30, 2023

Conversation

ShadauxCat
Copy link
Collaborator

@ShadauxCat ShadauxCat commented Aug 24, 2023 •
edited by NoelStephensUnity
Loading

MTT-7202

fix: #2671

Changelog

  • Added: Added methods NetworkManager.SetPeerMTU and NetworkManager.GetPeerMTU to be able to set MTU sizes per-peer

Testing and Documentation

  • Includes unit tests.
  • No documentation changes or additions were necessary.

@ShadauxCat ShadauxCat requested a review from a team as a code owner August 24, 2023 20:32
@ShadauxCat
Changelog
30c8cc8
@ShadauxCat
-standards
3c20512 
-apparently GetValueOrDefault doesn't exist in CI?
NoelStephensUnity
NoelStephensUnity approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and clean Kitty!

@ShadauxCat ShadauxCat enabled auto-merge (squash) August 30, 2023 17:03
@ShadauxCat ShadauxCat merged commit a981703 into develop Aug 30, 2023
1 check passed
@ShadauxCat ShadauxCat deleted the feat/per_client_MTU branch August 30, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MTU Value is shared across all peers
3 participants
@ShadauxCat @NoelStephensUnity @netcode-ci-service