Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NetworkObject component should always precede NetworkBehaviour components [MTT-7216] #2685

Merged
merged 11 commits into from
Aug 30, 2023
Merged

fix: NetworkObject component should always precede NetworkBehaviour components [MTT-7216] #2685

merged 11 commits into from
Aug 30, 2023

Commits on Aug 29, 2023

  1. fix 

    MTT-7216
This resolves the issue where an in-scene placed NetworkObject can have NetworkBehaviour components not invoke the OnNetworkDespawn method when doing a full scene transition (LoadSceneMode.Single) due to the way GameObjects destroy the attached components.
    @NoelStephensUnity
    NoelStephensUnity committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    58b05df View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. update 

    adding check for null
    @NoelStephensUnity
    NoelStephensUnity committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    42362dc View commit details
    Browse the repository at this point in the history

  2. style 

    missed adding a white space
    @NoelStephensUnity
    NoelStephensUnity committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    e1eef5f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into fix/networkobject-component-should-preced… 

    …e-networkbehaviours
    @NoelStephensUnity
    NoelStephensUnity committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    dd9f3c0 View commit details
    Browse the repository at this point in the history

  4. test 

    This is a unit test to validate the re-ordering of the NetworkObject component.
    @NoelStephensUnity
    NoelStephensUnity committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    ec3e92b View commit details
    Browse the repository at this point in the history

  5. update 

    adding change log entry for this fix.
    @NoelStephensUnity
    NoelStephensUnity committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0c4a4b8 View commit details
    Browse the repository at this point in the history

  6. style 

    removing "auto-added" namespace...
    @NoelStephensUnity
    NoelStephensUnity committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    6abae26 View commit details
    Browse the repository at this point in the history

  7. style 

    removing un-used namespace.
    @NoelStephensUnity
    NoelStephensUnity committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    80598cd View commit details
    Browse the repository at this point in the history

  8. Update CHANGELOG.md 

    Adding PR number
    @NoelStephensUnity
    NoelStephensUnity authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    5553ba7 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into fix/networkobject-component-should-preced… 

    …e-networkbehaviours
    @NoelStephensUnity
    NoelStephensUnity authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    f255dfd View commit details
    Browse the repository at this point in the history

  10. Merge branch 'develop' into fix/networkobject-component-should-preced… 

    …e-networkbehaviours
    @NoelStephensUnity
    NoelStephensUnity authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    2333955 View commit details
    Browse the repository at this point in the history