fix: ClientNetworkTransform ownership change with half precision synchronization issues [MTT-7271] #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the issue with client authoritative network transforms and the random "noise" that would occur when transitioning ownership from a remote client back to the host-server. - Latent messages from the client would still be received and processed after ownership changed. - Ownership changed messages would proceed the NetworkTransform initialization state update message. Now ownership changed messages precede the NetworkTransform initialization state update message. - Clients could sometimes have the same network tick value even when the tick event had triggered, which for NetworkDeltaPosition would cause dropped state updates.
This is another bug in the validation test suite where removing an override of a virtual method that can still be overridden will throw an API validation error.
| @@ -2510,24 +2542,25 @@ public override void OnDestroy() | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public override void OnGainedOwnership() | |||
| public override void OnLostOwnership() | |||
There was a problem hiding this comment.
Leaving these here otherwise the validation test will fail even though a user can still override both methods (see OnGainedOwnership too).
| @@ -588,6 +588,7 @@ private void AllChildrenLocalTransformValuesMatch(bool useSubChild) | |||
| success = WaitForConditionOrTimeOutWithTimeTravel(AllChildObjectInstancesHaveChild); | |||
| Assert.True(success, "Timed out waiting for all instances to have parented a child!"); | |||
|
|
|||
There was a problem hiding this comment.
Both minor tweaks to this test will help prevent random edge case precision validation errors.
NoelStephensUnity
deleted the
fix/networktransform-halffloat-ownership-sync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue with owner to host-server ownership transfer where the synchronization could get corrupted by noise due to:
fix: #2628
Changelog
Testing and Documentation