-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose diagnostic error codes #225
Expose diagnostic error codes #225
Conversation
Thank you very much for your contribution! I've wanted to extract parts of #186 since a long time, since that one got too big at some point. I'll have a deeper look at this ASAP. |
@urfeex Any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again for tackling this. If we could restructure things a bit (and rename the ErrorCodeClient) so it could potentially be reused as a primary client with more features in future, I think we could get this merged.
include/ur_client_library/primary/robot_message/error_code_message.h
Outdated
Show resolved
Hide resolved
5a65f3e
to
93b0933
Compare
@jessica-chen-ocado as you just rebased on current master: Do you plan to continue working on this based on our discussions previously? |
There is a change in priority with my assigned tasks but yes I intend to work on this when I'm free and finish this PR. |
af13b93
to
b264b21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking almost good. It would be good to sort out the license headers before merging and I have a couple of suggestions. Thank you for following up on this. This should give us a solid base to implement more features from #186 in the future.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 72.62% 73.03% +0.40%
==========================================
Files 76 80 +4
Lines 2977 3059 +82
Branches 381 389 +8
==========================================
+ Hits 2162 2234 +72
Misses 614 614
- Partials 201 211 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jessica-chen-ocado If you could add license headers to the files you've added, I think we would be good to merge this. |
1520307
to
c798e80
Compare
fyi I have add the headers and rebased my branch. I'll let you handle the rest? Thanks! |
Thank you for coming back on this @jessica-chen-ocado I'll see what needs to be done and if I can do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we are good to go with that! I will do some final testing and then probably merge this. Thank you @jessica-chen-ocado for getting parts of #186, finally!
Older versions of PolyScope seem to require that.
If URsim's time in the container is running a bit slower than the caller's time, we raise an error.
This reverts commit 04b7ebf.
Since I've created the file while working at FZI, I left the copyright owner and the license as is.
37081c1
to
d400328
Compare
PR to parse UR10 error codes from diagnostic logs that are streamed on the Primary Interface port 30001