Update computeCommand to compute_command #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former has been marked deprecated in control_toolbox.
urfeex
force-pushed
the
update_control_toolbox_api
branch
from
87a149c to
76c2d02
Compare
|
Waiting for this until the next sync, as it is not worth it breaking binary builds in CI for removing a deprecation warning. |
|
Upstream control_toolbox has been released. That means, we can unblock this. |
|
@urfeex is the 'Coverage Build' expected to fail? |
Yes. We've updated for the new JTC API already, but install the released version in the coverage CI. |
urrsk
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former has been marked deprecated in control_toolbox.