Symbol construction fix. #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 26, 2016 17:59
Symbol is INTERN'ed in lower case when *print-case* is :downcase and oodml.lisp fails to compile.
Not the best approach but will have to do for now.
Lispworks: parameter SLOT-DEF in SLOT-VALUE-USING-CLASS() is a slot name not slot instance.
By default, Lispworks does not call the SLOT-VALUE-USING-CLASS() methods when reading or writing slot values but instead uses optimized accessors. This behaviour is disabled by setting the :OPTIMIZE-SLOT-ACCESS class option to NIL. This patch defaults to this behaviour unless overriden.
Non-recursive lock fails for ODBC as API attempts to reuse query objects since the same lock is utilized. (Better fix needed?)
|
This looks mostly good, though I am curious about your changes to the package files. I also dont understand the change from the :export clause of the defpackage to the (export) fn call with interned symbols - or why this was desirable or necessary? If it was desirable or necessary, why was it not done to all packages |
|
Actually did not intend to include the package export changes into the
pull request.
The reason for the selective modification (ODBC and DECIMAL packages) is
that I have other packages in the same image with the same name thus
resulting in a conflict. (Different symbols exported.)
…On 16/01/2017 23:15, Russ Tyndall wrote:
This looks mostly good, though I am curious about your changes to the
package files.
I also dont understand the change from the :export clause of the
defpackage to the (export) fn call with interned symbols - or why this
was desirable or necessary? If it was desirable or necessary, why was
it not done to all packages
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA91xsYQzBF9R2ZH9Z5lcE5zok6-RFU3ks5rS8_RgaJpZM4LV0BI>.
|
|
Sorry that I spaced on this for a year. Do you happen to remember what was wrong with the format variant vs the concatenate variant? I can see certain printer settings affecting the format. I am finally getting around to working on this again, so I am trying to integrate the important changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbol is INTERN'ed in lower case when print-case is :downcase and
oodml.lisp fails to compile.