Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol construction fix. #8

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 46 additions & 47 deletions db-odbc/odbc-package.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -16,54 +16,53 @@

(in-package #:cl-user)

#-#.(cl:if (cl:find-package "ODBC") '(and) '(or))
(defpackage #:odbc
(:use #:cl #:uffi)
(:export
#:database-library-loaded

#:*null*
#:+null-ptr+
#:+max-precision+
#:*info-output*
#:*time-format*
#:get-cast-long
#:%free-statement
#:%disconnect
#:%commit
#:%rollback
#:%sql-fetch
#:%sql-cancel
#:db-connect
#:%new-db-connection-handle
#:%new-environment-handle
#:%sql-connect
#:%sql-driver-connect
#:disable-autocommit
#:enable-autocommit
#:%sql-free-environment
#:%sql-data-sources
#:%sql-get-info
#:%sql-param-data
#:%sql-execute
#:%put-str
#:%sql-bind-parameter
#:%sql-prepare
#:sqlfetch
#:%bind-column
#:%allocate-bindings
#:%describe-column
#:%describe-columns
#:read-data
#:read-data-in-chunks
#:query-database
#:%new-statement-handle
#:%sql-exec-direct
#:result-columns-count
#:result-rows-count
#:sql-to-c-type
#:%list-tables
#:%table-statistics
#:%list-data-sources
)
(:documentation "This is the low-level interface ODBC."))
(in-package #:odbc)

(export '(database-library-loaded
*null*
+null-ptr+
+max-precision+
*info-output*
*time-format*
get-cast-long
%free-statement
%disconnect
%commit
%rollback
%sql-fetch
%sql-cancel
db-connect
%new-db-connection-handle
%new-environment-handle
%sql-connect
%sql-driver-connect
disable-autocommit
enable-autocommit
%sql-free-environment
%sql-data-sources
%sql-get-info
%sql-param-data
%sql-execute
%put-str
%sql-bind-parameter
%sql-prepare
sqlfetch
%bind-column
%allocate-bindings
%describe-column
%describe-columns
read-data
read-data-in-chunks
query-database
%new-statement-handle
%sql-exec-direct
result-columns-count
result-rows-count
sql-to-c-type
%list-tables
%table-statistics
%list-data-sources))
15 changes: 8 additions & 7 deletions sql/decimals.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,17 @@
;; WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

#-#.(cl:if (cl:find-package "DECIMALS") '(and) '(or))
(defpackage #:decimals
(:use #:cl)
(:export #:round-half-away-from-zero
#:format-decimal-number
#:parse-decimal-number
#:decimal-parse-error
#:define-decimal-formatter))

(:use #:cl))
(in-package #:decimals)

(export '(round-half-away-from-zero
format-decimal-number
parse-decimal-number
decimal-parse-error
define-decimal-formatter))


(defun round-half-away-from-zero (number &optional (divisor 1))

Expand Down
3 changes: 2 additions & 1 deletion sql/metaclasses.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,8 @@ implementations."

(macrolet
((safe-copy-value (name &optional default)
(let ((fn (intern (format nil "~A~A" 'view-class-slot- name ))))
(let ((fn (intern (concatenate 'string (symbol-name 'view-class-slot-)
(symbol-name name)))))
`(setf (slot-value esd ',name)
(or (when (slot-boundp dsd ',name)
(delistify-dsd (,fn dsd)))
Expand Down
11 changes: 7 additions & 4 deletions sql/ooddl.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,17 @@
(unless (slot-boundp instance slot-name)
(let ((*db-deserializing* t))
(cond
((join-slot-p slot-def)
((join-slot-p slot-object)
(setf (slot-value instance slot-name)
(if (view-database instance)
(fault-join-slot class instance slot-object)
;; TODO: you could in theory get a join object even if
;; its joined-to object was not in the database
nil
)))
((not-direct-normalized-slot-p class slot-def)
((not-direct-normalized-slot-p class slot-name)
(if (view-database instance)
(update-fault-join-normalized-slot class instance slot-def)
(update-fault-join-normalized-slot class instance slot-object)
(setf (slot-value instance slot-name) nil))))))))
(call-next-method))

Expand Down Expand Up @@ -240,7 +240,10 @@ strings."
(defclass ,class ,supers ,slots
,@(if (find :metaclass `,cl-options :key #'car)
`,cl-options
(cons '(:metaclass clsql-sys::standard-db-class) `,cl-options)))
(cons '(:metaclass clsql-sys::standard-db-class) `,cl-options))
#+lispworks
,@(unless (find :optimize-slot-access `,cl-options :key #'car)
`((:optimize-slot-access nil))))
(finalize-inheritance (find-class ',class))
(find-class ',class)))

Expand Down
6 changes: 3 additions & 3 deletions sql/utils.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,12 @@

#+lispworks
(defvar +lw-has-without-preemption+
#+lispworks6 nil
#-lispworks6 t)
#+(or lispworks6 lispworks7) nil
#-(or lispworks6 lispworks7) t)
#+lispworks
(defvar +lw-global-lock+
(unless +lw-has-without-preemption+
(mp:make-lock :name "CLSQL" :important-p nil :safep t :recursivep nil
(mp:make-lock :name "CLSQL" :important-p nil :safep t :recursivep t
:sharing t)))

(defmacro without-interrupts (&body body)
Expand Down