Remove Vertx test context from database tests #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moetto
force-pushed
the
refactor-db-tests-remove-vertx-testctx
branch
from
b91e758 to
41e3bdf
Compare
Unit and integration test coverage
|
Feature test coverage
|
Moetto
force-pushed
the
refactor-database-tests
branch
from
896ae49 to
dce8133
Compare
Moetto
force-pushed
the
refactor-db-tests-remove-vertx-testctx
branch
from
41e3bdf to
5e7deaf
Compare
It's easy to make mistakes with test context where tests pass where they shouldn't. Switch to more ergonomic runTest and coAwait so that errors pop up and stack traces are better.
Moetto
force-pushed
the
refactor-db-tests-remove-vertx-testctx
branch
from
5e7deaf to
40db82f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to make mistakes with test context where tests pass where they shouldn't. Switch to more ergonomic runTest and coAwait so that errors pop up and stack traces are better.