Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyEmojiMarkdown: Fix copying animated emojis #3179

Merged
merged 9 commits into from
Feb 4, 2025
Merged

Conversation

Tomsoz
Copy link
Contributor

@Tomsoz Tomsoz commented Jan 29, 2025

Discord animated emojis no longer have the extension .gif. They are now .webp with the query parameter animated=true passed to them. I've updated the copyEmojiMarkdown plugin to reflect this as it wasn't copying animated emojis correctly.

Copy link
Collaborator

@Nuckyz Nuckyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of still checking for the extension this should just check if url.pathname ends with "gif". Take a look at isGifUrl from EmoteCloner

Made it check if url.pathname ends with gif instead of finding extension.
@Tomsoz
Copy link
Contributor Author

Tomsoz commented Jan 31, 2025

Okay, I've made those changes now.
It does make a lot more sense to do it that way.

@Tomsoz Tomsoz requested a review from Nuckyz January 31, 2025 04:12
@Tomsoz
Copy link
Contributor Author

Tomsoz commented Feb 4, 2025

@Nuckyz
Any ETA on this getting merged some friends keep complaining that it doesn't copy right.
No rush just wondering?

src/plugins/copyEmojiMarkdown/index.tsx Outdated Show resolved Hide resolved
@Nuckyz Nuckyz changed the base branch from main to dev February 4, 2025 19:25
@Nuckyz Nuckyz changed the title Updated the way animated emojis are detected CopyEmojiMarkdown: Fix copying animated emojis Feb 4, 2025
@Nuckyz Nuckyz enabled auto-merge (squash) February 4, 2025 19:28
@Nuckyz Nuckyz merged commit 971e186 into Vendicated:dev Feb 4, 2025
1 check passed
nin0-dev pushed a commit to nin0-dev/Ninacord that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants