Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyEmojiMarkdown: Fix copying animated emojis #3179

Merged
merged 9 commits into from
Feb 4, 2025
Merged

CopyEmojiMarkdown: Fix copying animated emojis #3179

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4eec0e2
Updated getEmojiMarkdown to change the way Vencord detects an animate…
Jan 29, 2025
550f6ed
Updated extension finder to use new variable for consistency
Jan 29, 2025
cc5e078
Merge branch 'main' into main
Tomsoz Jan 30, 2025
fbf75b4
Merge branch 'Vendicated:main' into main
Tomsoz Jan 31, 2025
227ac24
Updated copy emoji markdown
Tomsoz Jan 31, 2025
45cfa5f
Merge branch 'main' into main
Tomsoz Jan 31, 2025
ed672f7
Merge branch 'main' into main
Tomsoz Feb 3, 2025
5a3edbf
Update src/plugins/copyEmojiMarkdown/index.tsx
Tomsoz Feb 4, 2025
c8dfc43
Merge branch 'dev' into main
Nuckyz Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/plugins/copyEmojiMarkdown/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,14 @@ function getEmojiMarkdown(target: Target, copyUnicode: boolean): string {
: `:${emojiName}:`;
}

const extension = target?.firstChild.src.match(
const imgSrc = target?.firstChild.src;
const url = new URL(imgSrc);
Tomsoz marked this conversation as resolved.
Show resolved Hide resolved
const isAnimated = url.searchParams.get("animated") === "true";
const extension = imgSrc.match(
/https:\/\/cdn\.discordapp\.com\/emojis\/\d+\.(\w+)/
)?.[1];

return `<${extension === "gif" ? "a" : ""}:${emojiName.replace(/~\d+$/, "")}:${emojiId}>`;
return `<${(isAnimated || extension === "gif") ? "a" : ""}:${emojiName.replace(/~\d+$/, "")}:${emojiId}>`;
}

const settings = definePluginSettings({
Expand All @@ -55,7 +58,7 @@ export default definePlugin({
settings,

contextMenus: {
"expression-picker"(children, { target }: { target: Target }) {
"expression-picker"(children, { target }: { target: Target; }) {
if (target.dataset.type !== "emoji") return;

children.push(
Expand Down