Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(format): allow formatting of all types of pointers #72

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

Viatorus
Copy link
Owner

@Viatorus Viatorus commented Oct 11, 2023

  • const and volatile void pointers are directly formatted
  • other pointer types (e.g. int*) can be formatted by using emio::ptr(...) (like fmt::ptr)

Fixes #69

@Viatorus Viatorus changed the title feat(format): allow formatting of all kinds of pointers feat(format): allow formatting of all types of pointers Oct 11, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1f161cf) 99.40% compared to head (cf39a07) 99.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          56       56           
  Lines        5869     5891   +22     
=======================================
+ Hits         5834     5856   +22     
  Misses         35       35           
Files Coverage Δ
include/emio/detail/format/formatter.hpp 98.72% <100.00%> (ø)
include/emio/formatter.hpp 100.00% <100.00%> (ø)
test/unit_test/test_format.cpp 99.64% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viatorus Viatorus merged commit eec5d5f into main Oct 12, 2023
11 checks passed
@Viatorus Viatorus deleted the feat/pointer branch October 12, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't format const pointers
2 participants