PR2: Adding ColorUtils namespace with functions to replace cv::viz::color calls in non-visualizer classes. #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR in a series of changes that aim to make building with the visualizer module optional and remove the cv::viz dependency from other modules. A number of different non-visualization classes include cv::viz, which we would like to optionally remove when building without visualization. In the majority of these cases, this is only to get cv::viz::Color values.
This PR adds a new ColorUtils namespace with inline Color related functions that can be used instead of cv::viz::Color functions in non-visualizer classes. Non-visualizer classes are updated to remove the cv::viz-related includes and make use of these new functions. Things to note:
testTracker.cpp
andtestOpticalFlowPredictor.cpp
the cv::viz::Color calls are not updated because those are part of larger cv::viz-dependent blocks that need to be handled differently (e.g. using #ifdef blocks to exclude that logic).Full design document:
Visualization Build Option Refactor for Kimera-VIO.pdf
Testing process
Build docker container for testing
Testing
Kimera-VIO/params/Euroc/flags/stereoVIOEuroc.flags
with your editor of choice and modify-- log_output
to true.-- log_output
to true.LOG_OUTPUT
variable from 0 to 1../stereoVIOEuroc.bash
.Then re-run Kimera-VIO as shown in step 2. You should be re-running with the same configuration options.
You should also be looking out for any differences in the visualizer behaviour.