-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many API Additions #184
Many API Additions #184
Conversation
333600f
to
5d52096
Compare
Force pushed a rebase to fix merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick review, most seems good!
common/src/main/java/org/vivecraft/api/client/VivecraftClientAPI.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/vivecraft/api/client/VivecraftClientAPI.java
Outdated
Show resolved
Hide resolved
8917e8b
to
3e3e6d1
Compare
Just as an update on this PR so it's in writing on the tracker, this PR is still alive, just that I'm low on time to work on it right now. I consider the PR itself practically done, just that I want to finish the example mod mentioned above so it can be used to fully bug-test the API in some way. This is how I caught the issue with world scale that was fixed in ca0aa50 and 4ef41f4. Once that's done and the merge conflicts are fixed, I'll ask for another round of reviews, though if people want to provide them sooner, feel free to. |
4ef41f4
to
f536442
Compare
Finally finished the example mod. It should test to some degree every feature of the API by adding a few custom items that use API features. Note that I haven't tested the mod under Forge, but all is tested and working under Fabric, and I don't see why this API wouldn't work under Forge. That said, this is ready for review, testing, and any feedback (bugs, API changes big or small, or any other feedback). |
f43f766
to
a35c153
Compare
should maybe add a method to get the current renderpass, and one to check if it's the first one |
Both sound good to me! I'll mark them as From what I remember of Vivecraft rendering, is the first render pass always |
it should be left, but we have a separate flag, that you should use |
Closing this PR, with #255 to take its place, which includes the requested ability to get the current render pass and if it's the first render pass. |
This PR adds a lot of additions to Vivecraft's API, making it about on-par with MC VR API. This PR is intended to replace MC VR API, though I plan to maintain MC VR API for the rest of the major Minecraft version this PR is merged into (as of writing, for the rest of Minecraft 1.20.x).
This PR also rewrites the
Tracker
system.Tracker
is now an interface instead of an abstract class, andEntryPoint
was replaced withTrackerTickType
.Lastly, this PR removes all beta markers from the API, with the exception of
isVanillaRenderPass()
. This can be reverted if wanted.I'm very much looking for feedback. Anything from method names, to organization, to behavior, I'm greatly interested in hearing it. Especially considering that the API should be prepared for Vivecraft to grow.
Some notable differences between this PR and MC VR API:
Tracker
s to run alongside Vivecraft's.EDIT: I'm currently developing an example mod that uses parts of the PR. It's pretty heavily commented, as it would hopefully make a good example if this PR is merged. Note that you should not look at any releases before version 2.0.0, as those were a showcase of MC VR API, rather than this PR.