Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: [1.20.4] Many API Additions #255

Draft
wants to merge 1 commit into
base: Multiloader-1.20.4
Choose a base branch
from

Conversation

hammy275
Copy link
Contributor

@hammy275 hammy275 commented Feb 24, 2024

A 1.20.4 port of #184 . This also adds a couple of new changes:

  • Moved isVanillaRenderPass() to the bottom of the file, since its still marked @Beta. Perhaps we want to make a VivecraftRenderingAPI or something, just for organization?
  • Added isFirstRenderPass() and getCurrentRenderPass(), as requested.

All features can be tested with this test mod. Note that the test mod itself has only been tested on Fabric, but should work in Forge.

@hammy275
Copy link
Contributor Author

hammy275 commented Aug 30, 2024

Rebased onto Multiloader-1.20.4. Haven't tested it, but there were only a handful of merge conflicts with very simple fixes for all of them. Should be good to test with the test mod linked above.

Unrelated, but if it makes life easier, I'm happy to rebase this after #284 is merged.

Comment on lines +31 to +35
/**
* @return Whether the player is using reversed hands.
*/
boolean usingReversedHands();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to be isLeftHanded() and update the javadoc accordingly.

@hammy275 hammy275 force-pushed the vivecraft-api-1.20.4 branch from e8198a4 to ab8b5d1 Compare December 1, 2024 20:51
@hammy275 hammy275 changed the title [1.20.4] Many API Additions Draft: [1.20.4] Many API Additions Dec 1, 2024
@hammy275 hammy275 marked this pull request as draft December 1, 2024 20:52
@hammy275
Copy link
Contributor Author

hammy275 commented Dec 1, 2024

This PR is now caught up with the big refactor, but is untested. That said, I've marked it as draft, as there's several changes I'd like to make, and because the catching up to the refactor is entirely untested beyond ensuring it builds. These changes include:

  • The renaming of reversed hands to left-handedness
  • Refactoring to not have two versions of VRData and VRDataImpl. Ideally, just the interface and the class should exist, without needing to do internal conversions for the API.
  • Rename ClientAPIImpl and APIImpl to VivecraftClientAPIImpl and VivecraftAPIImpl.
  • Move rendering stuff out of the client API and into a "rendering API" area.
  • Move haptic pulse triggering into VRPlayer, since it makes sense that once you have a VRPlayer, you should be able to trigger a haptic pulse on it.
  • FBT support once merged.
  • Update demo mod to include the above changes.

@hammy275 hammy275 force-pushed the vivecraft-api-1.20.4 branch 2 times, most recently from 426b2fe to b8c7771 Compare December 4, 2024 17:53
@hammy275
Copy link
Contributor Author

hammy275 commented Dec 4, 2024

Squashed everything into one commit for now to make rebasing less annoying and now rebased on top of the JOML changes. Still need to test and make the changes above, but that should happen soon.

@hammy275 hammy275 force-pushed the vivecraft-api-1.20.4 branch from b8c7771 to fc4e468 Compare December 21, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant