-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: [1.20.4] Many API Additions #255
base: Multiloader-1.20.4
Are you sure you want to change the base?
Draft: [1.20.4] Many API Additions #255
Conversation
7c311a2
to
e8198a4
Compare
Rebased onto Unrelated, but if it makes life easier, I'm happy to rebase this after #284 is merged. |
/** | ||
* @return Whether the player is using reversed hands. | ||
*/ | ||
boolean usingReversedHands(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to be isLeftHanded()
and update the javadoc accordingly.
e8198a4
to
ab8b5d1
Compare
This PR is now caught up with the big refactor, but is untested. That said, I've marked it as draft, as there's several changes I'd like to make, and because the catching up to the refactor is entirely untested beyond ensuring it builds. These changes include:
|
426b2fe
to
b8c7771
Compare
Squashed everything into one commit for now to make rebasing less annoying and now rebased on top of the JOML changes. Still need to test and make the changes above, but that should happen soon. |
b8c7771
to
fc4e468
Compare
A 1.20.4 port of #184 . This also adds a couple of new changes:
isVanillaRenderPass()
to the bottom of the file, since its still marked@Beta
. Perhaps we want to make aVivecraftRenderingAPI
or something, just for organization?isFirstRenderPass()
andgetCurrentRenderPass()
, as requested.All features can be tested with this test mod. Note that the test mod itself has only been tested on Fabric, but should work in Forge.