fix hadolint error (intel-analytics#9223)

docker/bigdl-k8s/Dockerfile

@@ -61,7 +61,7 @@ RUN apt-get update --fix-missing && \
     wget -P ${SPARK_HOME}/jars/ https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-slf4j-impl/2.17.1/log4j-slf4j-impl-2.17.1.jar
 
 
-ADD ./log4j2.xml ${SPARK_HOME}/conf/log4j2.xml
+COPY ./log4j2.xml ${SPARK_HOME}/conf/log4j2.xml
 RUN ln -fs /bin/bash /bin/sh
 RUN if [ $SPARK_VERSION = "3.4.1" ]; then \
         rm $SPARK_HOME/jars/okhttp-*.jar && \
@@ -85,7 +85,7 @@ ENV BIGDL_HOME                  /opt/bigdl-${BIGDL_VERSION}
 
 RUN apt-get update --fix-missing && \
     apt-get install -y apt-utils vim curl nano wget unzip git
-ADD ./download-bigdl.sh /opt
+COPY ./download-bigdl.sh /opt
 
 RUN chmod a+x /opt/download-bigdl.sh && \
     mkdir -p /opt/bigdl-examples/python
@@ -105,7 +105,6 @@ COPY --from=spark /opt/spark/kubernetes/dockerfiles/spark/entrypoint.sh /opt
 
 # stage.4
 FROM ubuntu:20.04
-MAINTAINER The BigDL Authors https://github.com/intel-analytics/BigDL
 ARG BIGDL_VERSION
 ARG SPARK_VERSION
 ARG SPARK_HOME

docker/bigdl/Dockerfile

@@ -57,8 +57,8 @@ RUN apt-get update --fix-missing && \
     wget -P ${SPARK_HOME}/jars/ https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-core/2.17.1/log4j-core-2.17.1.jar && \
     wget -P ${SPARK_HOME}/jars/ https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-slf4j-impl/2.17.1/log4j-slf4j-impl-2.17.1.jar
 
-ADD ./log4j2.xml ${SPARK_HOME}/conf/log4j2.xml
-ADD ./spark-defaults.conf ${SPARK_HOME}/conf/spark-defaults.conf
+COPY ./log4j2.xml ${SPARK_HOME}/conf/log4j2.xml
+COPY ./spark-defaults.conf ${SPARK_HOME}/conf/spark-defaults.conf
 RUN ln -fs /bin/bash /bin/sh
 RUN if [ $SPARK_VERSION = "3.4.1" ]; then \
         rm $SPARK_HOME/jars/okhttp-*.jar && \
@@ -79,7 +79,7 @@ ENV BIGDL_HOME                  /opt/bigdl-${BIGDL_VERSION}
 
 RUN apt-get update --fix-missing && \
     apt-get install -y apt-utils vim curl nano wget unzip  git
-ADD ./download-bigdl.sh /opt
+COPY ./download-bigdl.sh /opt
 
 RUN chmod a+x /opt/download-bigdl.sh && \
     mkdir -p /opt/bigdl-examples/python
@@ -118,7 +118,7 @@ COPY --from=spark /opt/jdk /opt/jdk
 COPY --from=spark /opt/spark /opt/work/spark-${SPARK_VERSION}
 COPY --from=bigdl /opt/bigdl-${BIGDL_VERSION} /opt/work/bigdl-${BIGDL_VERSION}
 
-ADD ./install-python-env.sh /opt
+COPY ./install-python-env.sh /opt
 RUN chmod a+x /opt/install-python-env.sh
 
 RUN apt-get update --fix-missing && \
@@ -140,8 +140,8 @@ RUN apt-get update --fix-missing && \
 RUN echo "source activate bigdl" > ~/.bashrc
 ENV PATH /usr/local/envs/bigdl/bin:$PATH
 
-ADD ./start-notebook.sh /opt/work
-ADD ./start-notebook-k8s.sh /opt/work
+COPY ./start-notebook.sh /opt/work
+COPY ./start-notebook-k8s.sh /opt/work
 RUN chmod a+x /opt/work/start-notebook.sh && \
     chmod a+x /opt/work/start-notebook-k8s.sh
 

docker/llm/finetune/lora/cpu/docker/Dockerfile

@@ -12,7 +12,7 @@ FROM mpioperator/intel as builder
 ARG http_proxy
 ARG https_proxy
 ENV PIP_NO_CACHE_DIR=false
-ADD ./requirements.txt /bigdl/requirements.txt
+COPY ./requirements.txt /bigdl/requirements.txt
 
 # add public key
 COPY --from=key-getter /root/intel-oneapi-archive-keyring.gpg /usr/share/keyrings/intel-oneapi-archive-keyring.gpg
@@ -56,8 +56,8 @@ RUN mkdir /bigdl/data && mkdir /bigdl/model && \
     echo "    UserKnownHostsFile /dev/null" >> /etc/ssh/ssh_config && \
     sed -i 's/#\(StrictModes \).*/\1no/g' /etc/ssh/sshd_config
 
-ADD ./bigdl-lora-finetuing-entrypoint.sh /bigdl/bigdl-lora-finetuing-entrypoint.sh
-ADD ./lora_finetune.py /bigdl/lora_finetune.py
+COPY ./bigdl-lora-finetuing-entrypoint.sh /bigdl/bigdl-lora-finetuing-entrypoint.sh
+COPY ./lora_finetune.py /bigdl/lora_finetune.py
 
 RUN chown -R mpiuser /bigdl
 USER mpiuser

docker/llm/finetune/qlora/xpu/docker/Dockerfile

@@ -35,4 +35,4 @@ RUN curl -fsSL https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-P
     pip install peft==0.5.0 datasets && \
     wget https://raw.githubusercontent.com/intel-analytics/BigDL/main/python/llm/example/GPU/QLoRA-FineTuning/qlora_finetuning.py
 
-ADD ./start-qlora-finetuning-on-xpu.sh /start-qlora-finetuning-on-xpu.sh
+COPY ./start-qlora-finetuning-on-xpu.sh /start-qlora-finetuning-on-xpu.sh

docker/llm/inference/cpu/docker/Dockerfile

@@ -6,7 +6,7 @@ ARG PIP_NO_CACHE_DIR=false
 
 ENV PYTHONUNBUFFERED=1
 
-ADD ./start-notebook.sh /llm/start-notebook.sh
+COPY ./start-notebook.sh /llm/start-notebook.sh
 
 # Install PYTHON 3.9
 RUN env DEBIAN_FRONTEND=noninteractive apt-get update && \

docker/llm/serving/cpu/docker/Dockerfile

@@ -7,8 +7,8 @@ ARG TINI_VERSION=v0.18.0
 # Disable pip's cache behavior
 ARG PIP_NO_CACHE_DIR=false
 
-ADD ./entrypoint.sh /opt/entrypoint.sh
-ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /sbin/tini
+COPY ./entrypoint.sh /opt/entrypoint.sh
+COPY https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /sbin/tini
 # Install Serving Dependencies
 RUN mkdir /llm && \
     cd /llm && \

ppml/base/Dockerfile

@@ -23,17 +23,17 @@ ENV MALLOC_ARENA_MAX                    4
 
 RUN mkdir -p /ppml/
 
-ADD ./bash.manifest.template /ppml/bash.manifest.template
-ADD ./Makefile /ppml/Makefile
-ADD ./init.sh /ppml/init.sh
-ADD ./clean.sh /ppml/clean.sh
+COPY ./bash.manifest.template /ppml/bash.manifest.template
+COPY ./Makefile /ppml/Makefile
+COPY ./init.sh /ppml/init.sh
+COPY ./clean.sh /ppml/clean.sh
 
 # These files ared used for attestation service and register MREnclave
-ADD ./register-mrenclave.py /ppml/register-mrenclave.py
-ADD ./verify-attestation-service.sh /ppml/verify-attestation-service.sh
+COPY ./register-mrenclave.py /ppml/register-mrenclave.py
+COPY ./verify-attestation-service.sh /ppml/verify-attestation-service.sh
 
-ADD ./_dill.py.patch /_dill.py.patch
-ADD ./python-pslinux.patch /python-pslinux.patch
+COPY ./_dill.py.patch /_dill.py.patch
+COPY ./python-pslinux.patch /python-pslinux.patch
 
 # Python3.9
 RUN env DEBIAN_FRONTEND=noninteractive apt-get update && \
@@ -124,9 +124,9 @@ RUN env DEBIAN_FRONTEND=noninteractive apt-get update && \
     cd /ppml
 
 
-ADD ./download_jars.sh /ppml
-ADD ./attestation.sh /ppml
-ADD ./encrypted-fsd.sh /ppml
+COPY ./download_jars.sh /ppml
+COPY ./attestation.sh /ppml
+COPY ./encrypted-fsd.sh /ppml
 
 RUN cd /ppml && \
     bash ./download_jars.sh

ppml/tdx/docker/trusted-bigdl-llm/finetune/docker/Dockerfile

@@ -66,10 +66,10 @@ RUN mkdir /ppml/data && mkdir /ppml/model && \
     echo "mpiuser ALL = NOPASSWD:SETENV: /opt/intel/oneapi/mpi/2021.9.0/bin/mpirun\nmpiuser ALL = NOPASSWD:SETENV: /usr/bin/python" > /etc/sudoers.d/mpivisudo && \
     chmod 440 /etc/sudoers.d/mpivisudo
 
-ADD ./bigdl_aa.py /ppml/bigdl_aa.py
-ADD ./quote_generator.py /ppml/quote_generator.py
-ADD ./worker_quote_generate.py /ppml/worker_quote_generate.py
-ADD ./get_worker_quote.sh /ppml/get_worker_quote.sh
+COPY ./bigdl_aa.py /ppml/bigdl_aa.py
+COPY ./quote_generator.py /ppml/quote_generator.py
+COPY ./worker_quote_generate.py /ppml/worker_quote_generate.py
+COPY ./get_worker_quote.sh /ppml/get_worker_quote.sh
 COPY --from=native /ppml/bigdl-lora-finetuing-entrypoint.sh /ppml/bigdl-lora-finetuing-entrypoint.sh
 COPY --from=native /ppml/lora_finetune.py /ppml/lora_finetune.py
 

ppml/tdx/docker/trusted-bigdl-llm/inference/Dockerfile

@@ -7,13 +7,13 @@ ARG TINI_VERSION=v0.18.0
 RUN mkdir -p /ppml/
 
 
-ADD ./fschat.diff /opt/fschat.diff
-ADD ./requirements.txt /opt/requirements.txt
-ADD ./entrypoint.sh /opt/entrypoint.sh
-ADD ./attestation_cli.py /opt/attestation_cli.py
-ADD ./attestation.sh /opt/attestation.sh
-ADD ./llama_cpp.patch /opt/llama_cpp.patch
-ADD ./llama.patch /opt/llama.patch
+COPY ./fschat.diff /opt/fschat.diff
+COPY ./requirements.txt /opt/requirements.txt
+COPY ./entrypoint.sh /opt/entrypoint.sh
+COPY ./attestation_cli.py /opt/attestation_cli.py
+COPY ./attestation.sh /opt/attestation.sh
+COPY ./llama_cpp.patch /opt/llama_cpp.patch
+COPY ./llama.patch /opt/llama.patch
 ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /sbin/tini
 
 

ppml/tdx/docker/trusted-bigdl-llm/serving/docker/Dockerfile

@@ -6,8 +6,8 @@ ARG https_proxy
 RUN mkdir -p /ppml/
 
 
-ADD ./entrypoint.sh /opt/entrypoint.sh
-ADD ./attestation.sh /opt/attestation.sh
+COPY ./entrypoint.sh /opt/entrypoint.sh
+COPY ./attestation.sh /opt/attestation.sh
 
 
 # Install bigdl-ppml

ppml/trusted-big-data-ml/scala/docker-occlum/Dockerfile

@@ -167,7 +167,7 @@ RUN mkdir /ppml && cd /ppml && \
     cd LightGBM && mkdir build && cd build && \
     cmake -DUSE_SWIG=ON -DUSE_SSL=1 .. && make -j4
 
-ADD ./install_python_with_conda.sh /opt
+COPY ./install_python_with_conda.sh /opt
 RUN cd /opt && bash ./install_python_with_conda.sh
 
 #add jindo sdk to support oss
@@ -178,7 +178,6 @@ RUN cd /opt && \
 
 FROM occlum/occlum:0.29.7-ubuntu20.04 as ppml
 
-MAINTAINER The BigDL Authors https://github.com/intel-analytics/BigDL
 ARG BIGDL_VERSION=2.4.0-SNAPSHOT
 ARG SPARK_VERSION
 ARG HADOOP_VERSION
@@ -209,7 +208,7 @@ COPY --from=tini /usr/local/bin/tini /sbin/tini
 # Add 01.org & key
 #RUN echo 'deb [arch=amd64] https://download.01.org/intel-sgx/sgx_repo/ubuntu bionic main' | tee /etc/apt/sources.list.d/intelsgx.list && \
 #    wget -qO - https://download.01.org/intel-sgx/sgx_repo/ubuntu/intel-sgx-deb.key | apt-key add -
-RUN echo 'deb [arch=amd64] https://download.01.org/intel-sgx/sgx_repo/ubuntu focal main' | sudo tee /etc/apt/sources.list.d/intel-sgx.list && \
+RUN echo 'deb [arch=amd64] https://download.01.org/intel-sgx/sgx_repo/ubuntu focal main' | tee /etc/apt/sources.list.d/intel-sgx.list && \
     wget -qO - https://download.01.org/intel-sgx/sgx_repo/ubuntu/intel-sgx-deb.key | apt-key add -
 # RUN echo 'deb [arch=amd64] https://occlum.io/occlum-package-repos/debian bionic main' | tee /etc/apt/sources.list.d/occlum.list && \
 #     wget -qO - https://occlum.io/occlum-package-repos/debian/public.key | apt-key add -
@@ -251,20 +250,20 @@ COPY --from=bigdl /opt/zoo-tutorials/tpch-pyspark/tpch.zip /opt/py-examples/tpch
 COPY --from=bigdl /opt/zoo-tutorials/tpch-pyspark/main.py /opt/py-examples/tpch/
 
 # Copy scripts & other files
-ADD ./run_spark_on_occlum_glibc.sh /opt/run_spark_on_occlum_glibc.sh
-ADD ./sqlSuites /opt/sqlSuites
-ADD ./log4j2.xml /opt/spark/conf/log4j2.xml
+COPY ./run_spark_on_occlum_glibc.sh /opt/run_spark_on_occlum_glibc.sh
+COPY ./sqlSuites /opt/sqlSuites
+COPY ./log4j2.xml /opt/spark/conf/log4j2.xml
 
 # For get_quote C compile
 RUN rm /root/demos/remote_attestation/dcap/c_app/dcap_c_test.c
-ADD ./dcap_c_test.c /root/demos/remote_attestation/dcap/c_app/
-ADD ./dcap-ppml.yaml /root/demos/remote_attestation/dcap/
-ADD ./get_quote_on_ppml.sh /root/demos/remote_attestation/dcap
+COPY ./dcap_c_test.c /root/demos/remote_attestation/dcap/c_app/
+COPY ./dcap-ppml.yaml /root/demos/remote_attestation/dcap/
+COPY ./get_quote_on_ppml.sh /root/demos/remote_attestation/dcap
 
 # For attestation
-ADD ./verify-attestation-service.sh /opt
-ADD ./print_enclave_signer.sh /opt
-ADD ./register.sh /opt
+COPY ./verify-attestation-service.sh /opt
+COPY ./print_enclave_signer.sh /opt
+COPY ./register.sh /opt
 
 COPY ./entrypoint.sh /opt/
 COPY ./ehsm_entry.sh /opt/
@@ -282,9 +281,9 @@ RUN chmod a+x /opt/entrypoint.sh && \
     rm -rf /var/run/aesmd
 
 # Add python lib
-ADD ./python-glibc.yaml /opt/python-glibc.yaml
+COPY ./python-glibc.yaml /opt/python-glibc.yaml
 COPY --from=bigdl /opt/python-occlum /opt/python-occlum
-ADD ./py-examples /opt/py-examples
+COPY ./py-examples /opt/py-examples
 
 # Prepare Bigdl python libs
 RUN unzip -o $BIGDL_HOME/python/bigdl-dllib-spark_${SPARK_VERSION}-${BIGDL_VERSION}-python-api.zip -d $BIGDL_HOME/python-lib && \

ppml/trusted-bigdata/Dockerfile

@@ -55,7 +55,7 @@ RUN cd /opt && \
     rm spark-${SPARK_VERSION}/examples/jars/spark-examples_2.12-$SPARK_VERSION.jar && \
     rm spark-${SPARK_VERSION}/jars/hadoop-common-3.2.0.jar && \
     rm spark-${SPARK_VERSION}/jars/hive-exec-2.3.7-core.jar
-ADD ./log4j2.xml /opt/spark-${SPARK_VERSION}/conf/log4j2.xml
+COPY ./log4j2.xml /opt/spark-${SPARK_VERSION}/conf/log4j2.xml
 # spark modification
 RUN cd /opt && \
     wget $SPARK_JAR_REPO_URL/spark-core_2.12-$SPARK_VERSION.jar && \
@@ -186,18 +186,18 @@ COPY --from=bigdata /opt/flink $FLINK_HOME
 COPY --from=bigdata /usr/local/bin/gosu /usr/local/bin/gosu
 COPY --from=bigdl /bigdl-${BIGDL_VERSION} ${BIGDL_HOME}
 
-ADD ./bigdl-ppml-submit.sh /ppml/bigdl-ppml-submit.sh
-ADD ./scripts /ppml/scripts
-ADD ./spark-executor-template.yaml /ppml/spark-executor-template.yaml
-ADD ./spark-driver-template.yaml /ppml/spark-driver-template.yaml
-ADD ./entrypoint.sh /opt/entrypoint.sh
-ADD ./flink-entrypoint.sh /opt/flink-entrypoint.sh
-ADD ./flink-k8s-template.yaml /ppml/flink-k8s-template.yaml
-ADD ./examples /ppml/examples
-ADD ./examples/jupyter /ppml/notebook
-ADD ./zeppelin /ppml/zeppelin
-ADD ./spark-executor-template-for-tdxvm.yaml /ppml/spark-executor-template-for-tdxvm.yaml
-ADD ./spark-driver-template-for-tdxvm.yaml /ppml/spark-driver-template-for-tdxvm.yaml
+COPY ./bigdl-ppml-submit.sh /ppml/bigdl-ppml-submit.sh
+COPY ./scripts /ppml/scripts
+COPY ./spark-executor-template.yaml /ppml/spark-executor-template.yaml
+COPY ./spark-driver-template.yaml /ppml/spark-driver-template.yaml
+COPY ./entrypoint.sh /opt/entrypoint.sh
+COPY ./flink-entrypoint.sh /opt/flink-entrypoint.sh
+COPY ./flink-k8s-template.yaml /ppml/flink-k8s-template.yaml
+COPY ./examples /ppml/examples
+COPY ./examples/jupyter /ppml/notebook
+COPY ./zeppelin /ppml/zeppelin
+COPY ./spark-executor-template-for-tdxvm.yaml /ppml/spark-executor-template-for-tdxvm.yaml
+COPY ./spark-driver-template-for-tdxvm.yaml /ppml/spark-driver-template-for-tdxvm.yaml
 
 ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /sbin/tini
 RUN rm $SPARK_HOME/jars/okhttp-*.jar && \
@@ -250,8 +250,8 @@ RUN rm $SPARK_HOME/jars/okhttp-*.jar && \
     unzip -o $BIGDL_HOME/python/bigdl-ppml-spark_${SPARK_VERSION}-${BIGDL_VERSION}-python-api.zip -d /ppml/bigdl-ppml/src && \
     unzip -o $BIGDL_HOME/python/bigdl-serving-spark_${SPARK_VERSION}-${BIGDL_VERSION}-python-api.zip -d /ppml/bigdl-ppml/src && \
     unzip -o $BIGDL_HOME/python/bigdl-spark_${SPARK_VERSION}-${BIGDL_VERSION}-python-api.zip -d /ppml/bigdl-ppml/src
-ADD azure /ppml/azure
-ADD ./start-notebook.sh /ppml/start-notebook.sh
+COPY azure /ppml/azure
+COPY ./start-notebook.sh /ppml/start-notebook.sh
 RUN chmod a+x /ppml/azure/create-aks.sh && \
     chmod a+x /ppml/azure/generate-keys-az.sh && \
     chmod a+x /ppml/azure/generate-password-az.sh && \

ppml/trusted-bigdl-llm/base/Dockerfile

@@ -11,8 +11,8 @@ ARG TINI_VERSION=v0.18.0
 ARG http_proxy
 ARG https_proxy
 
-ADD utils.diff /opt/utils.diff
-ADD llm_cli.diff /opt/llm_cli.diff
+COPY utils.diff /opt/utils.diff
+COPY llm_cli.diff /opt/llm_cli.diff
 ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /sbin/tini
 
 
@@ -48,7 +48,7 @@ RUN pip3 install --pre --upgrade bigdl-llm[all]==2.4.0b20230830 && \
     apt-get install -y libunwind8-dev && \
     mkdir /ppml/data
 
-ADD ./entrypoint.sh /opt/entrypoint.sh
+COPY ./entrypoint.sh /opt/entrypoint.sh
 RUN  chmod +x /opt/entrypoint.sh && \
      chmod +x /sbin/tini
 WORKDIR /ppml

ppml/trusted-deep-learning/base/Dockerfile

@@ -17,16 +17,16 @@ ARG CMAKE_PREFIX_PATH="/usr/local/lib/python3.9/dist-packages/:/usr/local/lib/"
 RUN mkdir /ppml/examples
 
 ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /sbin/tini
-ADD ./entrypoint.sh /opt/entrypoint.sh
+COPY ./entrypoint.sh /opt/entrypoint.sh
 
 # Small examples for PyTorch
-ADD ./mnist.py                   /ppml/examples/mnist.py
-ADD ./pert.py                    /ppml/examples/pert.py
-ADD ./pert_ipex.py               /ppml/examples/pert_ipex.py
-ADD ./pert_nano.py               /ppml/examples/pert_nano.py
-ADD ./load_save_encryption_ex.py /ppml/examples/load_save_encryption_ex.py
+COPY ./mnist.py                   /ppml/examples/mnist.py
+COPY ./pert.py                    /ppml/examples/pert.py
+COPY ./pert_ipex.py               /ppml/examples/pert_ipex.py
+COPY ./pert_nano.py               /ppml/examples/pert_nano.py
+COPY ./load_save_encryption_ex.py /ppml/examples/load_save_encryption_ex.py
 # Patch for datasets
-ADD ./filelock.patch             /filelock.patch
+COPY ./filelock.patch             /filelock.patch
 
 
 # PyTorch Dependencies

ppml/trusted-dl-serving/base/Dockerfile

@@ -147,7 +147,7 @@ COPY --from=temp /usr/local/lib/python3.9/dist-packages/transformers-4.28.1-py3.
 COPY --from=temp /usr/local/lib/python3.9/dist-packages/tokenizers* /usr/local/lib/python3.9/dist-packages/tokenizers.egg
 
 # Start Script for Torchserve, Tritonserver and TF-Serving
-ADD ./ppml /ppml
+COPY ./ppml /ppml
 
 #Tritonserver
 COPY --from=tritonserver /dl-serving/opt /opt
@@ -156,7 +156,7 @@ COPY --from=min_container /dl-serving /
 #TF-Serving
 COPY --from=tf-serving /usr/local/bin/tensorflow_model_server /usr/bin/tensorflow_model_server
 
-Add ./pslinux.patch /ppml/pslinux.patch
+COPY ./pslinux.patch /ppml/pslinux.patch
 
 # Dependencies
 RUN env DEBIAN_FRONTEND=noninteractive apt-get update && \