Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler send batches command #186

Closed
wants to merge 1 commit into from

Conversation

lullis
Copy link
Collaborator

@lullis lullis commented Feb 21, 2025

  • Calling lock_batch is not needed, given that batch.run already implements the state change at its very first step
  • Why create a method (send_start_message()) that just adds another layer of indirection to a logging function?
  • get_first_batch can be avoided by using queryset iterators.

@lullis lullis closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant