Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multithreaded send batches #218

Merged
merged 12 commits into from
Mar 7, 2025
Merged

Multithreaded send batches #218

merged 12 commits into from
Mar 7, 2025

Conversation

lullis
Copy link
Collaborator

@lullis lullis commented Mar 6, 2025

No description provided.

arcstur
arcstur requested changes Mar 6, 2025
View reviewed changes
Copy link
Member

@arcstur arcstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new send_batches is awesome!!

@arcstur
Copy link
Member

arcstur commented Mar 6, 2025 •
edited
Loading

One last but important thing. In uwsgi.ini we need to remove 2 lines from the attach-daemon ... send_batches. Now that only one is necessary, it should only have one. With that and the comments above, I think this is ready to be deployed and will be awesome to see this new send_batches in action! (solved)

@lullis lullis marked this pull request as ready for review March 7, 2025 19:37
@lullis lullis merged commit 11d93db into main Mar 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcstur arcstur arcstur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lullis @arcstur