-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoded several IAnimationBuffer virtual functions #157
Open
Mozz3d
wants to merge
14
commits into
WopsS:master
Choose a base branch
from
Mozz3d:IAnimationBuffer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f247303
Create animIAnimationBuffer.hpp
Mozz3d e87b077
Merge branch 'WopsS:master' into IAnimationBuffer
Mozz3d 9a4468b
Update IAnimationBuffer virtual functions
Mozz3d 498e1ae
Merge branch 'IAnimationBuffer' of https://github.com/Mozz3d/RED4ext.…
Mozz3d 1b8e5ee
This probably isn't necessary
Mozz3d b2fb951
Stub generated IAnimationBuffer
Mozz3d f54c627
Clang formatting upsets me
Mozz3d 4a26535
Added func defs for various IAnimationBuffer funcs
Mozz3d 333da0a
Update animIAnimationBuffer.hpp
Mozz3d ef68ec0
Fix func defs mistake
Mozz3d 03c3a14
Clang is the sound of my head hitting the table
Mozz3d a0a6d25
Fix func returns
Mozz3d 96018da
Fix return in animIAnimationBuffer.hpp
Mozz3d 0ef25e8
Clang again
Mozz3d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
include/RED4ext/Scripting/Natives/animIAnimationBuffer-inl.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
#pragma once | ||
|
||
#ifdef RED4EXT_STATIC_LIB | ||
#include <RED4ext/Scripting/Natives/animIAnimationBuffer.hpp> | ||
#endif | ||
|
||
RED4EXT_INLINE bool RED4ext::anim::IAnimationBuffer::Load() | ||
{ | ||
return false; | ||
} | ||
|
||
RED4EXT_INLINE bool RED4ext::anim::IAnimationBuffer::Unload() | ||
{ | ||
return false; | ||
} | ||
|
||
RED4EXT_INLINE bool RED4ext::anim::IAnimationBuffer::IsReady() | ||
{ | ||
return true; | ||
} | ||
|
||
RED4EXT_INLINE bool RED4ext::anim::IAnimationBuffer::HasInplaceCompressedBuffer() | ||
{ | ||
return true; | ||
} | ||
|
||
// returns AnimDataAddress but need ctor | ||
// maybe hook og func? | ||
RED4EXT_INLINE void RED4ext::anim::IAnimationBuffer::GetDataAddress() | ||
{ | ||
} | ||
|
||
RED4EXT_INLINE void RED4ext::anim::IAnimationBuffer::GetSize() | ||
{ | ||
} | ||
|
||
RED4EXT_INLINE void RED4ext::anim::IAnimationBuffer::GetExtraData() | ||
{ | ||
} | ||
|
||
RED4EXT_INLINE void RED4ext::anim::IAnimationBuffer::sub_138() | ||
{ | ||
} | ||
|
||
RED4EXT_INLINE bool RED4ext::anim::IAnimationBuffer::HasFallbackFrames() | ||
{ | ||
return false; | ||
} | ||
|
||
RED4EXT_INLINE void RED4ext::anim::IAnimationBuffer::sub_140() | ||
{ | ||
} | ||
|
||
RED4EXT_INLINE void RED4ext::anim::IAnimationBuffer::sub_148() | ||
{ | ||
} | ||
|
||
RED4EXT_INLINE void RED4ext::anim::IAnimationBuffer::CreateFallbackFrame() | ||
{ | ||
} | ||
|
||
RED4EXT_INLINE void RED4ext::anim::IAnimationBuffer::GatherInfo() | ||
{ | ||
} | ||
|
||
RED4EXT_INLINE bool RED4ext::anim::IAnimationBuffer::sub_168() | ||
{ | ||
return true; | ||
} | ||
|
||
RED4EXT_INLINE void RED4ext::anim::IAnimationBuffer::sub_170() | ||
{ | ||
} | ||
|
||
RED4EXT_INLINE bool RED4ext::anim::IAnimationBuffer::sub_178() | ||
{ | ||
return false; | ||
} | ||
|
||
RED4EXT_INLINE void RED4ext::anim::IAnimationBuffer::sub_180() | ||
{ | ||
} |
46 changes: 46 additions & 0 deletions
46
include/RED4ext/Scripting/Natives/animIAnimationBuffer.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
#pragma once | ||
|
||
#include <RED4ext/Common.hpp> | ||
#include <RED4ext/ISerializable.hpp> | ||
#include <RED4ext/Scripting/Natives/Generated/anim/AnimDataAddress.hpp> | ||
|
||
namespace RED4ext | ||
{ | ||
namespace anim | ||
{ | ||
struct IAnimationBuffer : ISerializable | ||
{ | ||
static constexpr const char* NAME = "animIAnimationBuffer"; | ||
static constexpr const char* ALIAS = NAME; | ||
|
||
virtual bool Initialize() = 0; | ||
virtual bool Load(); | ||
virtual bool Unload(); | ||
virtual bool IsReady(); | ||
virtual bool HasInplaceCompressedBuffer(); | ||
virtual bool sub_100() = 0; | ||
virtual float GetDuration() = 0; | ||
virtual float GetFPS() = 0; | ||
virtual void GetDataAddress(); | ||
virtual void GetSize(); | ||
virtual void GetNumExtraJoints() = 0; | ||
virtual void GetExtraData(); | ||
virtual void sub_138(); | ||
virtual bool HasFallbackFrames(); | ||
virtual void sub_140(); | ||
virtual void sub_148(); | ||
virtual void CreateFallbackFrame(); | ||
virtual void GatherInfo(); | ||
virtual bool sub_168(); | ||
virtual void sub_170(); | ||
virtual bool sub_178(); | ||
virtual void sub_180(); | ||
}; | ||
RED4EXT_ASSERT_SIZE(IAnimationBuffer, 0x30); | ||
} // namespace anim | ||
using animIAnimationBuffer = anim::IAnimationBuffer; | ||
} // namespace RED4ext | ||
|
||
#ifdef RED4EXT_HEADER_ONLY | ||
#include <RED4ext/Scripting/Natives/animIAnimationBuffer-inl.hpp> | ||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
#ifndef RED4EXT_STATIC_LIB | ||
#error Please define 'RED4EXT_STATIC_LIB' to compile this file. | ||
#endif | ||
|
||
#include <RED4ext/Scripting/Natives/animIAnimationBuffer-inl.hpp> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the the rest of the class is virtual, why do you need to define these methods then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you talking about defining the methods in general for IAnimationBuffer? Or the specific implementations?
If it's the latter case those are methods I found to have some level of base implementation, which I assumed could be relevant. But in hindsight it seems unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specific implementation for these methods https://github.com/WopsS/RED4ext.SDK/pull/157/files#diff-02e0f54aa59dc27be0144120e671cfde17e58c320b3d958b416466509d0605b9R7-R82.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mozz3d can you remove these implementations?