Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing a "white background" variation for Gallery captions #24896

Open
kjellr opened this issue Aug 28, 2020 · 6 comments
Open

Consider providing a "white background" variation for Gallery captions #24896

kjellr opened this issue Aug 28, 2020 · 6 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 28, 2020

The dark gradient background behind gallery captions can look pretty muddy when applied to a light image:

Screen Shot 2020-08-28 at 11 41 02 AM copy

We should consider allowing folks to choose a light variant of that background:

Screen Shot 2020-08-28 at 11 41 00 AM copy

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Block] Gallery Affects the Gallery Block - used to display groups of images labels Aug 28, 2020
@kjellr
Copy link
Contributor Author

kjellr commented Aug 28, 2020

It took a quick pass at this in #24897, but it would be cool if this color were user-adjustable (and would provide an accessibility warning if the contrast wasn't strong enough).

@mtias
Copy link
Member

mtias commented Aug 29, 2020

cc @nosolosw @jorgefilipecosta on ideas on how best to handle this. Also consider that links contained there can cause issues when they inherit color.

@mtias mtias added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Aug 29, 2020
@oandregal
Copy link
Member

We can add text & link color controls to the gallery block and then use the presence/absence of has-text-color to set the caption's color: inherit or white/black. Would be this in line with what you're thinking?

We need to adjust how we generate the UI controls for colors, as of today text and background colors are coupled. #24927

@richtabor
Copy link
Member

Do we know if this a real problem that needs solving? I'm not convinced adding this much more complexity to the Gallery block (a new styles panel, colors panel, or both would be worth the end result.

If it is a real problem that we have feedback on, what if we lean towards an automated black/white solution that works based on the darkness level detected per each image?

@mtias
Copy link
Member

mtias commented Sep 1, 2020

It might be interesting to use @ItsJonQ work on #22564 to maybe generate a bg color matching the dominant color of the image automatically.

@kjellr
Copy link
Contributor Author

kjellr commented Sep 1, 2020

Do we know if this a real problem that needs solving? I'm not convinced adding this much more complexity to the Gallery block (a new styles panel, colors panel, or both would be worth the end result.

I think at the core of it, this is really just meant to solve help address situations where the caption awkwardly overlaps the image. To that end, I'm still hoping we eventually get a version where captions do not overlap the images at all: #8030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants