-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider providing a "white background" variation for Gallery captions #24896
Comments
It took a quick pass at this in #24897, but it would be cool if this color were user-adjustable (and would provide an accessibility warning if the contrast wasn't strong enough). |
cc @nosolosw @jorgefilipecosta on ideas on how best to handle this. Also consider that links contained there can cause issues when they inherit color. |
We can add text & link color controls to the gallery block and then use the presence/absence of We need to adjust how we generate the UI controls for colors, as of today text and background colors are coupled. #24927 |
Do we know if this a real problem that needs solving? I'm not convinced adding this much more complexity to the Gallery block (a new styles panel, colors panel, or both would be worth the end result. If it is a real problem that we have feedback on, what if we lean towards an automated black/white solution that works based on the darkness level detected per each image? |
I think at the core of it, this is really just meant to solve help address situations where the caption awkwardly overlaps the image. To that end, I'm still hoping we eventually get a version where captions do not overlap the images at all: #8030 |
The dark gradient background behind gallery captions can look pretty muddy when applied to a light image:
We should consider allowing folks to choose a light variant of that background:
The text was updated successfully, but these errors were encountered: