Try a white style variant for gallery caption backgrounds #24897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Enhancement
|
Size Change: +129 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Aug 31, 2020
| @@ -57,6 +57,12 @@ | |||
| font-size: $default-font-size; | |||
| background: linear-gradient(0deg, rgba($color: $black, $alpha: 0.7) 0, rgba($color: $black, $alpha: 0.3) 70%, transparent); | |||
|
|
|||
| // White background variation | |||
| .is-style-white-caption-background & { | |||
| color: inherit; | |||
There was a problem hiding this comment.
I think we could add user-selected colors for the caption and links within. In that case, would it make sense that this color is opinionated (black-ish) if the user hasn't selected any color?
There was a problem hiding this comment.
I do like the idea of the user providing the colors and having some defaults.
The gradient has actually been slightly headachy because it doesn't work with multiple lines. Not that we can change it easily, but I do like the idea of Global Styles expanding the palette here.
|
Closing this out due to inactivity. Will ensure the attached issue remains open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #24896 by adding a white gradient background variant for gallery captions.
Potential concerns:
Screenshot: