Add post author biography block #38269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
New Block
4 tasks
|
Size Change: +150 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
carolinan
requested review from
ajitbohra,
mkaz,
spacedmonkey and
TimothyBJacobs
as code owners
aristath
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
This looks good @carolinan!
The code is simple and makes sense, the block works as advertised and gets the job done.
I'll go ahead and approve this, I don't see anything wrong with it.
Let's leave it for a few days so that others can also test it before it gets merged, see if anything else comes up 👍
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a post author biography (description) block.
Partial for #35596
Supports
Padding, margin, colors, font size (visible by default), line height,
font appearance panel, letter spacing, letter case and font family.
-A decision about these settings need to be made before merging.
Testing Instructions
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).