Update pattern overrides to use a hard coded support array #57912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the soon to be removed block bindings global
talldan
added
[Type] Task
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-supports/pattern.php |
aaronrobertshaw
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
LGTM 👍
✅ Allowed blocks matches process_block_bindings function
✅ Tests as per instructions in #53705 (comment)
✅ Fixes fatal PHP error on trunk currently
Fatal error: Uncaught TypeError: array_key_exists): Argument #2 ($array) must be of type array
talldan
deleted the
update/pattern-overrides-to-use-hardcoded-support-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #53705.
In #57742, the public global
$block_bindings_allowed_blocksvariable will be removed in favour of private code.This PR removes the pattern overrides dependency on that array, so that things don't break when #57742 is merged.
How?
Duplicates the array. While this isn't great for maintenance, it should be fine while the list of supported blocks/attributes is small and unlikely to change much.
Testing Instructions
Follow the instructions in #53705 (comment), and ensure overrides still work for headings, paragraphs and buttons