-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library: Typo fixes #58243
Font Library: Typo fixes #58243
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/tests/fonts/font-library/wpFontCollection/__construct.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/isConfigValid.php |
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
I noticed this PR was merged after I raised the PHP Sync Tracking Issue for WP 6.5 and has changed PHP files that may need backporting to WP Core. I assume it will be covered in the effort to merge the Fonts API in a single backport commit? |
Yes, this will be included in the single backport PR for the font library. |
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: f739080 |
* Fix typo in library-font-variant.js * Fix typos in __construct.php * Fix typos in isConfigValid.php
* Fix typo in library-font-variant.js * Fix typos in __construct.php * Fix typos in isConfigValid.php
What?
Small PR to tidy up some typos.