Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Typo fixes #58243

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Font Library: Typo fixes #58243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed28291
Fix typo in library-font-variant.js
mikachan Jan 25, 2024
7608ed5
Fix typos in __construct.php
mikachan Jan 25, 2024
6fcefd7
Fix typos in isConfigValid.php
mikachan Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/edit-site/src/components/global-styles/font-library-modal/library-font-variant.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function LibraryFontVariant( { face, font } ) {
const { isFontActivated, toggleActivateFont } =
useContext( FontLibraryContext );

const isIstalled =
const isInstalled =
font?.fontFace?.length > 0
? isFontActivated(
font.slug,
Expand Down Expand Up @@ -52,7 +52,7 @@ function LibraryFontVariant( { face, font } ) {
<Flex justify="space-between" align="center" gap="1rem">
<FontFaceDemo fontFace={ face } text={ displayName } />
<CheckboxControl
checked={ isIstalled }
checked={ isInstalled }
onChange={ handleToggleActivation }
__nextHasNoMarginBottom={ true }
id={ checkboxId }
Expand Down
6 changes: 3 additions & 3 deletions phpunit/tests/fonts/font-library/wpFontCollection/__construct.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ public function test_should_initialize_data() {
}

/**
* @dataProvider data_should_do_ti_wrong
* @dataProvider data_should_do_it_wrong
*
* @param mixed $config Config of the font collection.
*/
public function test_should_do_ti_wrong( $config ) {
public function test_should_do_it_wrong( $config ) {
$this->setExpectedIncorrectUsage( 'WP_Font_Collection::is_config_valid' );
new WP_Font_Collection( $config );
}
Expand All @@ -65,7 +65,7 @@ public function test_should_do_ti_wrong( $config ) {
*
* @return array
*/
public function data_should_do_ti_wrong() {
public function data_should_do_it_wrong() {
return array(
'no id' => array(
array(
Expand Down
6 changes: 3 additions & 3 deletions phpunit/tests/fonts/font-library/wpFontCollection/isConfigValid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,16 @@ public function data_is_config_valid() {
}

/**
* @dataProvider data_is_config_valid_should_call_doing_ti_wrong
* @dataProvider data_is_config_valid_should_call_doing_it_wrong
*
* @param mixed $config Config of the font collection.
*/
public function test_is_config_valid_should_call_doing_ti_wrong( $config ) {
public function test_is_config_valid_should_call_doing_it_wrong( $config ) {
$this->setExpectedIncorrectUsage( 'WP_Font_Collection::is_config_valid', 'Should call _doing_it_wrong if the config is not valid.' );
$this->assertFalse( WP_Font_Collection::is_config_valid( $config ), 'Should return false if the config is not valid.' );
}

public function data_is_config_valid_should_call_doing_ti_wrong() {
public function data_is_config_valid_should_call_doing_it_wrong() {
return array(
'with missing slug' => array(
'config' => array(
Expand Down
Loading