Editor: Animate the inserter and list view panels #60665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
draganescu,
jameskoster,
jasmussen and
ellatrix
|
So far this breaks zoom-out mode because:
We should either:
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Also, I don't really understand why the patterns inserter behaves differently between post and site editors, it should behave the same way IMO. |
|
Size Change: +283 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Apr 11, 2024
If we want to have an experience where you compose pages with patterns, i.e. an "Add new page" flow where you browse and add patterns to a page without having to go in-and-out of the inserter, we can't have the sidebar covering the page. |
|
If we do animate these sidebars ideally they'd use the same easing as the inspector/global styles. If you open the inserter, then open list view, there's a jump that would be good to eliminate (similar issue to the one in #60561 when switching between inspector + global styles). |
Yes, let's bring zoom out to the post editor so we can make these 1:1. |
|
I think this PR was not ready to merge :) you folks are too quick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #60561
Related to #60423
What?
This PR animates the left sidebar of the post and site editors (opening and closing the sidebar).
Testing Instructions