Block Editor: Remove 'rootClientId' argument for block lock selectors #62547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: -66 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Mamaduka
changed the title
Mamaduka
changed the title
Mamaduka
requested review from
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
requested review from
ntsekouras and
t-hamano
and removed request for
juanmaguitar,
ajitbohra,
ryanwelcher,
ndiego and
fabiankaegy
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
Mamaduka
force-pushed
the
update/can-remove-block-selectors
branch
from
4ab3d66 to
f39e81c
Compare
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…WordPress#62547) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: richtabor <[email protected]>
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
…#62547) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: richtabor <[email protected]>
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
…#62547) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: richtabor <[email protected]>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 313031f |
ellatrix
added
Backported to WP Core
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
…#62547) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: richtabor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #62368.
Supersedes #62374.
Supersedes #62430.
PR updates block locking selectors and remove the need to pass the
rootClientIdargument. The argument is now always derived from' clientId`. Similar to #37453.Why?
The "move" and "remove" actions should be checked relative to the root block. Omitting it can cause bugs like #62368.
Testing Instructions
The block locking has good e2e test coverage.
Testing Instructions for Keyboard
Same.