DateFormatPicker: fix styles & spacing #68079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +23 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in a18914f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12389020166
|
|
@fabiankaegy Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67917
Related to #67290
What?
This PR resolves two issues in the
DateFormatPickercomponent:fieldsetelement when no reset style from WordPress existsAs a result, the issue reported in #67917 (comment) will be fixed.
Why?
I discovered this issue while looking into #67290 and #67906.
When this component is displayed inside a WordPress page, it has no border, padding or margin due to the reset styles in WordPress core.
Additionally, #67906 caused this setting to be refactored to use a
ToolsPanelItem, which negates the bottom margin expected by the inspector control:This component may be used outside of WordPress, for example in the developer's own block editor, so we need to ensure that it displays with the correct layout wherever it is displayed.
How?
fieldsetelementVStackcomponentTesting Instructions
Storybook
npm run storybook:devDate Block