-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Fix emotion/is-prop-valid
warning
#68202
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
Flaky tests detected in e44b61a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12434441860
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one, thanks 👍
What?
This PR resolves the last warning we see on load in Storybook (after #68198 and #68199 tackled the other five).
Why?
Just fixing a warning.
How?
Adding
emotion/is-prop-valid
as a specific dev dependency because currently it's declared as an optional peer dependency:https://github.com/motiondivision/motion/blob/6ddb3e79685653f18a863f64f76c3fb5fade1903/packages/framer-motion/package.json#L94-L102
Testing Instructions
package-lock.json
, just shifting existing ones around.Testing Instructions for Keyboard
Same
Screenshots or screencast