Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated @emotion/is-valid-prop #2531

Merged

Conversation

iam-medvedev
Copy link
Contributor

@iam-medvedev iam-medvedev commented Feb 26, 2024

Changed the way the @emotion/is-valid-prop dependency is defined.

Optional peer dependency is less strict - it doesn't touch the lockfile signature and allows you to use any version in your project.

NOTE: I chose the * version and it's safe since the package API has never changed.

Closes #2530

iam-medvedev and others added 3 commits February 26, 2024 14:21
Changed the way the `@emotion/is-valid-prop` dependency is defined.

Optional peer dependency is less strict - it doesn't touch the lockfile signature and allows you to use any version in your project.

NOTE: I chose the `*`` version and it's safe since the package API has never changed.

Closes motiondivision#2530
@mattgperry
Copy link
Collaborator

Great, thanks for this!

@mergetron mergetron bot merged commit 885aff7 into motiondivision:main Mar 12, 2024
1 check passed
@nimaa77
Copy link

nimaa77 commented Mar 15, 2024

this change broke my app after I upgraded to 11.0.13

the error says

Import trace for requested module:
./node_modules/framer-motion/dist/es/render/dom/utils/filter-props.mjs
./node_modules/framer-motion/dist/es/index.mjs
./src/components/Header/Header.tsx
 ⚠ ./node_modules/framer-motion/dist/es/render/dom/utils/filter-props.mjs
Module not found: Can't resolve '@emotion/is-prop-valid' in 'node_modules/framer-motion/dist/es/render/dom/utils'

Import trace for requested module:
./node_modules/framer-motion/dist/es/render/dom/utils/filter-props.mjs
./node_modules/framer-motion/dist/es/index.mjs
./src/components/Header/Header.tsx

@iam-medvedev
Copy link
Contributor Author

@nimaa77 Could you provide code that can be reproduced?

@SPodjasek
Copy link

@nimaa77 I get similar errors with Meteor projects.

Everything seems to work as usual, but you can see warnings like the one below on server console:

Unable to resolve some modules:

  "@emotion/is-prop-valid" in                 
..../node_modules/framer-motion/dist/es/render/dom/utils/filter-props.mjs
(web.browser)
                                              
If you notice problems related to these missing modules, consider running:
                                              
  meteor npm install --save @emotion/is-prop-valid

@italodeandra
Copy link

italodeandra commented Aug 7, 2024

 ⚠ ./node_modules/framer-motion/dist/cjs/index.js
Module not found: Can't resolve '@emotion/is-prop-valid' in 'C:\Users\user\WebstormProjects\marketplace-ui\node_modules\framer-motion\dist\cjs'

Import trace for requested module:
./node_modules/framer-motion/dist/cjs/index.js

Getting this error from all 11.*.* versions.

@tyxla
Copy link

tyxla commented Dec 20, 2024

 ⚠ ./node_modules/framer-motion/dist/cjs/index.js
Module not found: Can't resolve '@emotion/is-prop-valid' in 'C:\Users\user\WebstormProjects\marketplace-ui\node_modules\framer-motion\dist\cjs'

Import trace for requested module:
./node_modules/framer-motion/dist/cjs/index.js

Getting this error from all 11.*.* versions.

We solved this error by specifically adding emotion/is-prop-valid as a dev dependency (see WordPress/gutenberg#68202).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @emotion/is-prop-valid version duplicates
6 participants