-
-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated @emotion/is-valid-prop
#2531
Updated @emotion/is-valid-prop
#2531
Conversation
Changed the way the `@emotion/is-valid-prop` dependency is defined. Optional peer dependency is less strict - it doesn't touch the lockfile signature and allows you to use any version in your project. NOTE: I chose the `*`` version and it's safe since the package API has never changed. Closes motiondivision#2530
Great, thanks for this! |
this change broke my app after I upgraded to the error says
|
@nimaa77 Could you provide code that can be reproduced? |
@nimaa77 I get similar errors with Meteor projects. Everything seems to work as usual, but you can see warnings like the one below on server console:
|
Getting this error from all |
We solved this error by specifically adding |
Changed the way the
@emotion/is-valid-prop
dependency is defined.Optional peer dependency is less strict - it doesn't touch the lockfile signature and allows you to use any version in your project.
NOTE: I chose the
*
version and it's safe since the package API has never changed.Closes #2530